Initial shot at structural equal and bug fixes in cpp_generator.py #15
Conversation
objectgen/objectgen/object_def.py
Outdated
| @@ -15,6 +15,7 @@ class ObjectField: | |||
| field_name: str | |||
| field_type: Type | |||
| is_binding: bool = False | |||
| check_equality: bool = True | |||
There was a problem hiding this comment.
Would it make sense for this to be called is_metadata?
There was a problem hiding this comment.
In the case of Spans, that makes sense, but I also had to set this false for function names. if function names can also count as metadata I think it works
There was a problem hiding this comment.
arguably function names are meta data if you are only looking at structure
There was a problem hiding this comment.
I think we should keep it generic potentially like use_in_{equal/hash/etc} this is pretty much deriving for all of object gen so it shouldn't be specific to AST imo
| @@ -51,11 +52,6 @@ def __init__(self, definition_scope, diag_ctx): | |||
| self.module = {} | |||
| super().__init__() | |||
|
|
|||
| def span_to_span(self, span): | |||
There was a problem hiding this comment.
I don't think this code is equivalent to tvm_span_from_synr, we need to be really careful about the string -> source name mapping.
* Get initial version of structural equality working * Fix typo in objectgen * Cpp generator bug * Respond to comments
* Get initial version of structural equality working * Fix typo in objectgen * Cpp generator bug * Respond to comments
* Get initial version of structural equality working * Fix typo in objectgen * Cpp generator bug * Respond to comments
I added a method to do structural equality and changed the way relax SEqualReduce methods are generated and also some basic structural equality tests
The structural equality method only works on functions not relax modules right now, since relax modules are just dictionaries right now (are we going to change the relax modules to be an object? if not then I can just loop through that dictionary in the assert_structural_equal method).