Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force brighter color with XML syntax highlighting #1943

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

micahellison
Copy link
Member

@micahellison micahellison commented Oct 19, 2024

Fixes #1934.

Our docs use a couple competing highlight.css files, I think due to something in the mkdocs framework that conflicts with the highlight.css file in our theme. Accessibility checks fail on only string in one XML snippet, which is clearly too dark for its background, so I'm overriding the style in that particular case.

It's not the most elegant solution, but I don't want to sink more time into these style sheet issues now that our accessibility checks are passing. Better solutions are welcome if anyone else wants to tackle this.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

@micahellison micahellison added the documentation Improvements or additions to documentation label Oct 19, 2024
@micahellison micahellison merged commit 1143fba into develop Oct 19, 2024
2 checks passed
@micahellison micahellison deleted the a11y-syntax-highlight branch October 19, 2024 21:28
edoardob90 added a commit to edoardob90/jrnl that referenced this pull request Nov 16, 2024
* Update dependency ruff to v0.6.8 (jrnl-org#1900)

* Update dependency ruff to v0.6.8

* Run `ruff check .` instead of `ruff .` due to ruff error

* Preface ruff lint keys with .lint to address ruff deprecation warning

* Changes to appease ruff linter

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com>

* Update changelog [ci skip]

* Update dependency cryptography to v42.0.8 (jrnl-org#1904)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency requests to v2.32.3 (jrnl-org#1899)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency mkdocs to v1.6.1 (jrnl-org#1895)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency jinja2 to v3.1.4 (jrnl-org#1892)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency python-dateutil to v2.9.0 (jrnl-org#1898)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update changelog [ci skip]

* Update dependency pytest-bdd to v7.3.0 (jrnl-org#1896)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency black to v24.8.0 (jrnl-org#1923)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency keyring to v25.4.1 (jrnl-org#1924)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency parse-type to v0.6.3 (jrnl-org#1922)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency pytest-xdist to v3.6.1 (jrnl-org#1897)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency poethepoet to v0.29.0 (jrnl-org#1925)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency rich to v13.8.1 (jrnl-org#1926)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update changelog [ci skip]

* Add calendar heatmap display format (jrnl-org#1759)

* Add calendar heatmap exporter

Fix jrnl-org#743

* Lint fixes

* More lint fixes

* Surface total number of entries per month in heatmap

* Refactoring

* More refactoring

* Resolve last lint error

* Unbump version

* Add calendar export test scaffolding

* WIP: Test debugging + scaffolding

* Remove broken tests

* Remove args from .vscode/launch.json

* Discard changes to tests/bdd/features/format.feature

* Remove extraneous vscode files

* move NestedDict to utils file

* run formatter

* fix import error

* Address lints

---------

Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com>
Co-authored-by: Jonathan Wren <jonathan@nowandwren.com>

* Update dependency cryptography to v43 (jrnl-org#1928)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency rich to v13.9.1 (jrnl-org#1931)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency tox to v4.21.0 (jrnl-org#1927)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update changelog [ci skip]

* Add config to pa11y to workaround github actions issue (jrnl-org#1933)

fixes jrnl-org#1932

* Add Python 3.13 support (jrnl-org#1930)

* Allow Python 3.13 in pyproject

* Add Python 3.13 to GitHub actions

* Run `poetry update`

* fix failing test

* update poetry.lock

* update poetry.lock again

---------

Co-authored-by: Jonathan Wren <jonathan@nowandwren.com>

* Update changelog [ci skip]

* Update dependency cryptography to v43.0.3 (jrnl-org#1942)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency black to v24.10.0 (jrnl-org#1939)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency tox to v4.23.0 (jrnl-org#1935)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update changelog [ci skip]

* Update dependency rich to v13.9.2 (jrnl-org#1937)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency ruff to v0.7.0 (jrnl-org#1938)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update changelog [ci skip]

* Update dependency parse-type to v0.6.4 (jrnl-org#1936)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update changelog [ci skip]

* Update dependency xmltodict to v0.14.2 (jrnl-org#1940)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update changelog [ci skip]

* Update dependency typed.js to v2.1.0 (jrnl-org#1861)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update changelog [ci skip]

* Update peter-evans/create-pull-request action to v7 (jrnl-org#1929)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Force brighter color with XML syntax highlighting (jrnl-org#1943)

* Update changelog [ci skip]

* Changelog cleanup (jrnl-org#1944)

* Sort packages and and remove extraneous entries

* Move docs accessibility issues to docs section

* Increment version to v4.2-beta

* Update changelog [ci skip]

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com>
Co-authored-by: Jrnl Bot <bot@jrnl.sh>
Co-authored-by: Aaron Lichtman <aaronlichtman@gmail.com>
Co-authored-by: Jonathan Wren <jonathan@nowandwren.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs accessibility checker failure - contrast ratio
1 participant