Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Dependencies #3669

Closed
wants to merge 2 commits into from
Closed

Updates Dependencies #3669

wants to merge 2 commits into from

Conversation

CDAGaming
Copy link
Contributor

@CDAGaming CDAGaming commented May 12, 2017

Summary

This PR Updates the Following Dependencies:

  • Babel-Preset-ES2015: v6.6.0 > v6.24.1 (Minor)
  • CommitPlease: v2.6.1 > v2.7.10 (Minor)
  • Core-JS: v2.2.2 > v2.4.1 (Minor)
  • Cross-Spawn: v2.2.3 > v5.1.0 (Major)
  • ESlint-Config-JQuery: v1.0.0 > v1.0.1 (Minor)
  • Grunt-Contrib-Uglify: v1.0.1 > v3.0.1 (Major)
  • Grunt-JSONLint: v1.0.7 > v1.1.0 (Minor)
  • Grunt-Newer: v1.2.0 > v1.3.0 (Minor)
  • Husky: v0.11.4 > v0.13.4 (Minor)
  • Insight: v0.8.1 > 0.8.4 (Minor)
  • Load-Grunt-tasks: v3.5.0 > v3.5.2 (Minor)
  • Q: v1.4.1 > v1.5.0 (Minor)
  • QUnit-Assert-Step: v1.0.3 > v1.1.1 (Minor)
  • QUnitJS: v1.23.1 > v2.3.2 (Major)
  • RequireJS: v2.2.0 > v2.3.3 (Minor)
  • Simon: v1.17.3 > v2.3.2 (Major)

Checklist

N/A

@mention-bot
Copy link

@CDAGaming, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mgol, @all3fox and @gibson042 to be potential reviewers.

@alisianoi
Copy link

Merging this PR right now will cause commitplease to be silently ignored by husky, I am investigating it.

@CDAGaming
Copy link
Contributor Author

Nice, Thanks :)

@mgol
Copy link
Member

mgol commented May 13, 2017

Thanks for the PR.

Have you verified tests work after upgrading to QUnit 2? I tried that some time ago and they were failing.

@CDAGaming
Copy link
Contributor Author

I do not remember the exact results @mgol, so ill rerun tests in a few hours, and will note results

@CDAGaming
Copy link
Contributor Author

@mgol Yup, definitely errors on testing
2017-05-13 4

@CDAGaming
Copy link
Contributor Author

Will see if it's specifically QUnit causing this or another dependency(Pretty sure it's one of the major update dependencies if not QUnit)

@mgol
Copy link
Member

mgol commented May 14, 2017

@CDAGaming This error is unrelated, maybe the Promises/A+ tests are not working on Windows on cmd.exe? Have you tried Git Bash?

I was talking about running the unit tests; you need to open a test page manually in a browser to see if it passes the tests.

@CDAGaming
Copy link
Contributor Author

@mgol Sorry for the Late Response, and it seems that it was passing the tests, although even with git bash i was unable to do npm run test on either official(this) or my PR Fork

@CDAGaming
Copy link
Contributor Author

JSDom v6.0.0+ are not compatible
jsdom/jsdom@3c156b8

@mgol mgol mentioned this pull request May 31, 2017
2 tasks
@timmywil
Copy link
Member

timmywil commented Jun 5, 2017

@CDAGaming How about we isolate all of the dependencies that we know can be updated without issues and do those first?

@CDAGaming
Copy link
Contributor Author

Ok, that would be the Minor Updated Dependencies(Ex: v1.2.3 to v1.2.4 or v1.2.3 to v1.3.4 NOT v1.2.3 to v2.0.0)

@CDAGaming
Copy link
Contributor Author

I've updated the description as well as here are the Major Dep Updates:

  • Cross-Spawn: v2.2.3 > v5.1.0 (Major)
  • Grunt-Contrib-Uglify: v1.0.1 > v3.0.1 (Major)
  • QUnitJS: v1.23.1 > v2.3.2 (Major)
  • Simon: v1.17.3 > v2.3.2 (Major)

@mgol
Copy link
Member

mgol commented Jun 5, 2017

@CDAGaming Not necessarily. A lot of times breaking changes are in APIs we don't use; I'd say even most of times. What's needed is to update the deps and see if our build process/tests still work. Or look at the changelogs of updated libraries to read about breaking changes.

@CDAGaming
Copy link
Contributor Author

Ah, Okay. I'll individually tests these dependencies and see which ones have breaking changes

@timmywil
Copy link
Member

Merged in 31783e6

@timmywil timmywil closed this Jun 26, 2017
timmywil pushed a commit to timmywil/jquery that referenced this pull request Jun 26, 2017
@CDAGaming CDAGaming deleted the patch-1 branch July 12, 2017 05:15
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants