-
Notifications
You must be signed in to change notification settings - Fork 20.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Dependencies #3669
Updates Dependencies #3669
Conversation
@CDAGaming, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mgol, @all3fox and @gibson042 to be potential reviewers. |
Merging this PR right now will cause |
Nice, Thanks :) |
Thanks for the PR. Have you verified tests work after upgrading to QUnit 2? I tried that some time ago and they were failing. |
I do not remember the exact results @mgol, so ill rerun tests in a few hours, and will note results |
@mgol Yup, definitely errors on testing |
Will see if it's specifically QUnit causing this or another dependency(Pretty sure it's one of the major update dependencies if not QUnit) |
@CDAGaming This error is unrelated, maybe the Promises/A+ tests are not working on Windows on cmd.exe? Have you tried Git Bash? I was talking about running the unit tests; you need to open a test page manually in a browser to see if it passes the tests. |
@mgol Sorry for the Late Response, and it seems that it was passing the tests, although even with git bash i was unable to do npm run test on either official(this) or my PR Fork |
JSDom v6.0.0+ are not compatible |
@CDAGaming How about we isolate all of the dependencies that we know can be updated without issues and do those first? |
Ok, that would be the Minor Updated Dependencies(Ex: v1.2.3 to v1.2.4 or v1.2.3 to v1.3.4 NOT v1.2.3 to v2.0.0) |
I've updated the description as well as here are the Major Dep Updates:
|
@CDAGaming Not necessarily. A lot of times breaking changes are in APIs we don't use; I'd say even most of times. What's needed is to update the deps and see if our build process/tests still work. Or look at the changelogs of updated libraries to read about breaking changes. |
Ah, Okay. I'll individually tests these dependencies and see which ones have breaking changes |
Merged in 31783e6 |
- Also ignore yarn.lock Close jquerygh-3669
Summary
This PR Updates the Following Dependencies:
Checklist
N/A