Build: Fix an XSS in the test server HTML serving logic #2309
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test server has a rule for `/tests/unit/*/*.html` paths that serves a proper local file. However, the parameters after `/unit/` were so far not escaped, leading to possibly reading a file from outside of the Git repository. Fix that by replacing non-alphanumeric characters that are also not `-` or `_`. This should resolve one CodeQL alert.
mgol
force-pushed
the
codeql-createTestServer
branch
from
fba692e
to
84164d6
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const html = await readFile( | ||
| `tests/unit/${ req.params[ 0 ] }/${ req.params[ 0 ] }.html`, | ||
| `tests/unit/${ moduleEscaped }/${ moduleEscaped }.html`, |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High test
There was a problem hiding this comment.
Funny, considering this is exactly the issue I'm fixing in this PR...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test server has a rule for
/tests/unit/*/*.htmlpaths that serves a proper local file. However, the parameters after/unit/were so far not escaped, leading to possibly reading a file from outside of the Git repository. Fix that by replacing non-alphanumeric characters that are also not-or_.This should resolve one CodeQL alert.