Tabs: Use CSS.escape for sanitizing selectors
#2307
+38
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
commented
Oct 25, 2024
Comment on lines
-315
to
-317
| _sanitizeSelector: function( hash ) { | ||
| return hash ? hash.replace( /[!"$%&'()*+,.\/:;<=>?@\[\]\^`{|}~]/g, "\\$&" ) : ""; | ||
| }, |
There was a problem hiding this comment.
@fnagel It's internal only so I thought we can just remove it. Or should we be conservative & only deprecate in 1.14? I don't know how jQuery UI historically approached removing private widget methods.
There was a problem hiding this comment.
I see there's at least one case of $.fn._focus getting renamed to $.fn.focus between 1.10.1 & 1.10.2: 1.10.1...1.10.2
mgol
force-pushed
the
tabs-sanitize-selector
branch
from
d57df64
to
7f64617
Compare
mgol
force-pushed
the
tabs-sanitize-selector
branch
from
7f64617
to
cd43cb6
Compare
timmywil
approved these changes
Oct 25, 2024
The previous private `_sanitizeSelector` API was not correctly escaping backslashes and is now removed. The native API should always be correct.
mgol
force-pushed
the
tabs-sanitize-selector
branch
from
cd43cb6
to
3112528
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous private
_sanitizeSelectorAPI was not correctly escaping backslashes and is now removed. The native API should always be correct.