Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Mark jQuery.fn.load( [ eventData ], handler ) as removed #482

Merged
merged 3 commits into from
Apr 5, 2023

Conversation

jp41011
Copy link
Contributor

@jp41011 jp41011 commented Jan 30, 2023

I think that jquery.fn.unload() should have the "is deprecated and removed" label. .unload() was deprecated in jquery v1.8 and removed in v3.0 So if you get this "warning" it will not actually work once you remove the jquery migrate plugin.

Reference: https://api.jquery.com/unload/

I think that jquery.fn.unload() should have the "is deprecated and removed" label.
.unload() was deprecated in jquery v1.8 and removed in v3.0
So if you get this "warning" it will not actually work once you remove the jquery migrate plugin.

Reference: https://api.jquery.com/unload/
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 30, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@mgol
Copy link
Member

mgol commented Jan 30, 2023

Thanks. Please sign our CLA.

Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for signing the CLA. I missed it as signing the CLA doesn't send GitHub notifications in itself.

I added one comment.

warnings.md Show resolved Hide resolved
Updates warning to make it more clear that jQuery.fn.load( [eventData], handler ) was deprecated and removed.
This is different from the AJAX-related `.load()` method.
We do mention the AJAX-related method in the **Cause:** section.
warnings.md Outdated Show resolved Hide resolved
@mgol mgol added this to the 3.5.0 milestone Apr 5, 2023
@mgol mgol changed the title Update warnings.md - jquery.fn.unload() Docs: Mark jQuery.fn.load( [ eventData ], handler ) as removed Apr 5, 2023
@mgol mgol merged commit 4bbafb7 into jquery:main Apr 5, 2023
@mgol mgol modified the milestones: 3.5.0, 3.4.2 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants