-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a new jinja2 templating process to update library to latest unicode (14.0) #61
Conversation
working towards generating C code for fast table lookup, and to provide a platform to generate code for other languages.
This comment was marked as outdated.
This comment was marked as outdated.
This pull request fixes 2 alerts when merging bbe041b into 4d45480 - view on LGTM.com fixed alerts:
|
JINJA_ENV = jinja2.Environment( | ||
loader=jinja2.FileSystemLoader(os.path.join(PATH_UP, 'code_templates')), | ||
keep_trailing_newline=True) |
Check warning
Code scanning / CodeQL
Jinja2 templating with autoescape=False
name_start, name_end = '(nil)', '(nil)' | ||
try: | ||
name_start = string.capwords(unicodedata.name(ucs_start)) | ||
except ValueError: |
Check notice
Code scanning / CodeQL
Empty except
pass | ||
try: | ||
name_end = string.capwords(unicodedata.name(ucs_end)) | ||
except ValueError: |
Check notice
Code scanning / CodeQL
Empty except
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the help, I'll merge & release in ~8 hours or so, I just want to be sure I am home to address any issues in release, and maybe address a few small open issues as well, #22, #24, #55, #56.
With any luck I will be able to work on Cythonification tomorrow, I found this stack overflow solution that addresses my concern, that we can include a cython or c extension as optional and fallback to pure python if it is not able to compile, https://stackoverflow.com/questions/41778153/compiling-an-optional-cython-extension-only-when-possible-in-setup-py
Thanks for your efforts! Everything LGTM.
This anwser looks really old, we have |
tox.ini
,requirements*
filespip-compile
with "requirements.in" files to generate "requirements.txt" files.j2
) templating to generate code and documentation,--check-last-modified
will compare last-modified for redownloadfor wcwidth/table*.py
files