Read the Docs configuration fixes #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #262 +/- ##
=======================================
Coverage 95.38% 95.38%
=======================================
Files 9 9
Lines 1018 1018
Branches 215 215
=======================================
Hits 971 971
Misses 43 43
Partials 4 4 ☔ View full report in Codecov by Sentry. |
|
I've added you as maintainer, but this should work, I'll go ahead and merge and see. |
|
Thanks! Read the Docs builds are working again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed Read the Docs builds are failing. We need to specify the OS. Unfortunately they haven't added support a latest tag on the OS yet.
I also moved the Python version to the new location and changed it to only specify the major version so it should use the latest supported.
I couldn't test this, but we could enable PR builds in RTD. Or add me as a maintainer in RTD and I'll do it.