Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double-installed doc #2482

Merged
merged 3 commits into from
Jun 16, 2023
Merged

Fix double-installed doc #2482

merged 3 commits into from
Jun 16, 2023

Conversation

h3xx
Copy link
Contributor

@h3xx h3xx commented Sep 9, 2022

Remove redundant README

The README symlink was causing the file (a regular file) to be installed twice in , once as README and once as README.md with the exact same contents.

h3xx added 2 commits August 26, 2022 16:58
@h3xx
Use autotools standard ${docdir}
630ae72 
Specified with `--docdir=<path>`, the `$(docdir)` variable is already
available, and has the same default as what it was being set to.

By specifying it here, it overrides what the `--docdir` option
specifies.
@h3xx
Remove redundant README
4cd72e4 
The README symlink was causing the file to be installed twice in
<DOCDIR>.
@h3xx h3xx marked this pull request as ready for review September 9, 2022 18:48
@liquidaty liquidaty mentioned this pull request Mar 7, 2023
Closed
@itchyny itchyny added the build label Jun 3, 2023
itchyny
itchyny reviewed Jun 9, 2023
View reviewed changes
Copy link
Contributor

@itchyny itchyny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to list COPYING and AUTHORS here, because automake automatically includes the files if found. Also, we will not need to list README.md here because it includes automatically (when README does not exist), but this is a new feature introduced in automake 1.16.4 in Jul 2021, so let's keep this (I believe we don't even need this line in the future). Correct me if my understanding is wrong.

itchyny
itchyny approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@itchyny itchyny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering the adoption of .md detection in automake, no one would against the distribution with only README.md. So I'll include this, thanks.

@itchyny itchyny merged commit 38b42e5 into jqlang:master Jun 16, 2023
owenthereal pushed a commit to owenthereal/jq that referenced this pull request Jun 17, 2023
@h3xx @owenthereal
Fix double-installed doc (jqlang#2482)
d8c7539 
The README symlink was causing the file to be installed twice in
<DOCDIR>.
owenthereal pushed a commit to owenthereal/jq that referenced this pull request Jun 17, 2023
@h3xx @owenthereal
Fix double-installed doc (jqlang#2482)
2d38843 
The README symlink was causing the file to be installed twice in
<DOCDIR>.
owenthereal pushed a commit to owenthereal/jq that referenced this pull request Jun 17, 2023
@h3xx @owenthereal
Fix double-installed doc (jqlang#2482)
2fbdba9 
The README symlink was causing the file to be installed twice in
<DOCDIR>.
owenthereal pushed a commit to owenthereal/jq that referenced this pull request Jun 17, 2023
@h3xx @owenthereal
Fix double-installed doc (jqlang#2482)
8fdcea0 
The README symlink was causing the file to be installed twice in
<DOCDIR>.
owenthereal pushed a commit to owenthereal/jq that referenced this pull request Jun 17, 2023
@h3xx @owenthereal
Fix double-installed doc (jqlang#2482)
dbd0ef9 
The README symlink was causing the file to be installed twice in
<DOCDIR>.
owenthereal pushed a commit to owenthereal/jq that referenced this pull request Jun 17, 2023
@h3xx @owenthereal
Fix double-installed doc (jqlang#2482)
184e621 
The README symlink was causing the file to be installed twice in
<DOCDIR>.
owenthereal pushed a commit to owenthereal/jq that referenced this pull request Jun 17, 2023
@h3xx @owenthereal
Fix double-installed doc (jqlang#2482)
4918dc5 
The README symlink was causing the file to be installed twice in
<DOCDIR>.
owenthereal pushed a commit to owenthereal/jq that referenced this pull request Jun 17, 2023
@h3xx @owenthereal
Fix double-installed doc (jqlang#2482)
5ebaf9b 
The README symlink was causing the file to be installed twice in
<DOCDIR>.
owenthereal pushed a commit to owenthereal/jq that referenced this pull request Jun 17, 2023
@h3xx @owenthereal
Fix double-installed doc (jqlang#2482)
e155d93 
The README symlink was causing the file to be installed twice in
<DOCDIR>.
owenthereal pushed a commit to owenthereal/jq that referenced this pull request Jun 17, 2023
@h3xx @owenthereal
Fix double-installed doc (jqlang#2482)
9c7e7d4 
The README symlink was causing the file to be installed twice in
<DOCDIR>.
owenthereal pushed a commit to owenthereal/jq that referenced this pull request Jun 17, 2023
@h3xx @owenthereal
Fix double-installed doc (jqlang#2482)
8516c0e 
The README symlink was causing the file to be installed twice in
<DOCDIR>.
owenthereal pushed a commit to owenthereal/jq that referenced this pull request Jun 17, 2023
@h3xx @owenthereal
Fix double-installed doc (jqlang#2482)
d23586f 
The README symlink was causing the file to be installed twice in
<DOCDIR>.
owenthereal pushed a commit to owenthereal/jq that referenced this pull request Jun 17, 2023
@h3xx @owenthereal
Fix double-installed doc (jqlang#2482)
3df7bbc 
The README symlink was causing the file to be installed twice in
<DOCDIR>.
owenthereal pushed a commit to owenthereal/jq that referenced this pull request Jun 17, 2023
@h3xx @owenthereal
Fix double-installed doc (jqlang#2482)
299a3ab 
The README symlink was causing the file to be installed twice in
<DOCDIR>.
owenthereal pushed a commit to owenthereal/jq that referenced this pull request Jun 17, 2023
@h3xx @owenthereal
Fix double-installed doc (jqlang#2482)
d5ac454 
The README symlink was causing the file to be installed twice in
<DOCDIR>.
owenthereal pushed a commit to owenthereal/jq that referenced this pull request Jun 17, 2023
@h3xx @owenthereal
Fix double-installed doc (jqlang#2482)
6e06e69 
The README symlink was causing the file to be installed twice in
<DOCDIR>.
owenthereal pushed a commit to owenthereal/jq that referenced this pull request Jun 17, 2023
@h3xx @owenthereal
Fix double-installed doc (jqlang#2482)
aa136b8 
The README symlink was causing the file to be installed twice in
<DOCDIR>.
owenthereal pushed a commit to owenthereal/jq that referenced this pull request Jun 17, 2023
@h3xx @owenthereal
Fix double-installed doc (jqlang#2482)
4575204 
The README symlink was causing the file to be installed twice in
<DOCDIR>.
owenthereal pushed a commit to owenthereal/jq that referenced this pull request Jun 17, 2023
@h3xx @owenthereal
Fix double-installed doc (jqlang#2482)
26e714b 
The README symlink was causing the file to be installed twice in
<DOCDIR>.
owenthereal pushed a commit to owenthereal/jq that referenced this pull request Jun 17, 2023
@h3xx @owenthereal
Fix double-installed doc (jqlang#2482)
bc3b8d5 
The README symlink was causing the file to be installed twice in
<DOCDIR>.
@itchyny itchyny mentioned this pull request Jun 28, 2023
Merged
@itchyny itchyny mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itchyny itchyny itchyny approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h3xx @itchyny