Dockerfile build fix: oniguruma doesn't have a distclean target #1429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to build a docker image from
master
(because I needed@base64d
), and the build failed saying there was no "distclean" target for oniguruma. Removing the corresponding command from the Dockerfile fixed this; presumably the need to delete oniguruma build files is sufficiently met later in the Dockerfile, by the already-existingrm -rf oniguruma-5.9.6
command.