Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile build fix: oniguruma doesn't have a distclean target #1429

Closed
wants to merge 1 commit into from

Conversation

pjeby
Copy link

@pjeby pjeby commented Jun 15, 2017

I was trying to build a docker image from master (because I needed @base64d), and the build failed saying there was no "distclean" target for oniguruma. Removing the corresponding command from the Dockerfile fixed this; presumably the need to delete oniguruma build files is sufficiently met later in the Dockerfile, by the already-existing rm -rf oniguruma-5.9.6 command.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.932% when pulling e06ca5c on pjeby:patch-1 into c538237 on stedolan:master.

@rmetzler rmetzler mentioned this pull request Mar 19, 2018
@pjeby
Copy link
Author

pjeby commented Feb 19, 2019

Closing in favor of #1631

@pjeby pjeby closed this Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants