Make administrator model compatible to authorizable interface #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some packages which uses the Spatie-Permissions like Spati-Mailcoach require a Administrator Model which is compatible with the Authorizable Interface.
You get this error then:
"Spatie\Permission\PermissionRegistrar::Spatie\Permission{closure}(): Argument #1 ($user) must be of type Illuminate\Contracts\Auth\Access\Authorizable, Dcat\Admin\Models\Administrator given"
As a solution I need to copy the whole model and HasPermission Trait to make it compatible, because you cannot simply override the "can" method. This is a very ugly solution, because I need to track changes on the Administrator model and the HasPermission Trait on dcat-updates.
This PR makes the Administrator Model compatible with the Authorizable Interface. Very simple changes nothing with impact. Not sure if you want to add this PR, maybe its a nice to have if some Spatie-Admin-Tools (or others) are compatible without problems.