Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tabular figures #27

Closed
jpt opened this issue Dec 25, 2017 · 10 comments
Closed

add tabular figures #27

jpt opened this issue Dec 25, 2017 · 10 comments
Assignees

Comments

@jpt
Copy link
Owner

jpt commented Dec 25, 2017

I've had a couple requests for this, seems like a common enough feature to support

@jpt jpt self-assigned this Dec 25, 2017
@JulietaUla
Copy link

Hello Jeremy
Do you have the tabular lining numbers?

@jpt
Copy link
Owner Author

jpt commented Jan 17, 2018

Hi @JulietaUla -- not sure if you got my response previously, but I think I will get to these in the next couple of weeks! I will keep you updated

@JulietaUla
Copy link

GREAT!!! Thank you :)

@jpt jpt closed this as completed in 06deac1 Mar 4, 2018
@jpt
Copy link
Owner Author

jpt commented Mar 4, 2018

Hi @JulietaUla -- sorry this took so much longer than expected, but tabular figures are now in!

@abersager
Copy link

@jpt Thanks so much for adding the tabular figures.

I haven't been able to get this to work, unfortunately. I can see the corresponding glyphs in Glyphs.app, but I can't access them in the browser through font-feature-settings: 'tnum' or font-variant-numeric: tabular-nums.

It's not a problem with the browser; when using Gotham, which supports both proportional and tabular figures, the numbers are displayed correctly.

I've created a pen to demonstrate the issue: https://codepen.io/abersager/pen/PRZpVY
image

I'd be very grateful if you could let me know whether I'm doing something wrong.

@jpt
Copy link
Owner Author

jpt commented Mar 13, 2018

@abersager Thanks for letting me know, I am reopening this issue until I push a fix. I believe the OpenType features were simply not compiled into the font binaries despite the glyphs existing, so it shouldn't be hard, I just need to find the time -- next couple of days, I'm sure!

@jpt jpt reopened this Mar 13, 2018
@davelab6
Copy link

Well, this codepen uses the fonts via Google Fonts API, which strips out non-essential opentype features, so it will not work even when @jpt has updated the binaries and submitted a pull request to github.com/google/fonts and that is merged and pushed

@abersager
Copy link

@jpt Thanks very much!

@davelab6 You're right, not a good example. I haven't managed to get it to work with locally installed fonts, either.

@JulietaUla
Copy link

JulietaUla commented Mar 23, 2018 via email

@jpt
Copy link
Owner Author

jpt commented Mar 23, 2018

Thank you @JulietaUla for testing out the tabular figures! I’ll push out a new version of Barlow for everyone on Monday or so (fixes an issue with tcaron as well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants