Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix underscore method for single letter words #131

Merged
merged 1 commit into from
Mar 16, 2015

Conversation

az7arul
Copy link
Collaborator

@az7arul az7arul commented Mar 16, 2015

This deals with #86

@jprichardson
Copy link
Owner

Looks good to me.

@az7arul
Copy link
Collaborator Author

az7arul commented Mar 16, 2015

@jprichardson whats the build process ? should I just merge this ?

@jprichardson
Copy link
Owner

Change process:

  1. Submit PR for significant changes (wait for acknowledgement), minor changes like bugfixes it's ok to commit directly yourself.
  2. Adhere to semver. Best explanation I've found of semver http://semver-ftw.org/
  3. You can use tin to alter versions for all package files https://github.com/jprichardson/tin.
  4. Make sure to update CHANGELOG.md.
  5. Run make min. (We should move to gulp)
  6. Commit the new version number with commit message being the version number. Should contain only the version number changes in package files, changelog changes, and new min file.
  7. Create a tag with with the version number. Tag message should be the changelog changes.
  8. Push and npm publish. Btw, what is your npm username?

@az7arul
Copy link
Collaborator Author

az7arul commented Mar 16, 2015

az7arul

@jprichardson
Copy link
Owner

Done.

@az7arul az7arul merged commit c228b6b into jprichardson:master Mar 16, 2015
@az7arul
Copy link
Collaborator Author

az7arul commented Mar 16, 2015

Published to npm :)

@jprichardson
Copy link
Owner

👍 Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants