Update fs promise shims to support latest Node functions #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort array to match Node docs
RyanZim
changed the title
manidlou
reviewed
Feb 1, 2020
| it('returns an object', () => { | ||
| return fs.writev(TEST_FD, TEST_DATA, 0) | ||
| .then(({ bytesWritten, buffers }) => { | ||
| assert.strictEqual(bytesWritten, SIZE, 'bytesWritten is correct') |
There was a problem hiding this comment.
I believe the message should be the opposite, something like bytesWritten is incorrect since that is used as the message for AssertionError if the values are not strictly equal. It is the same for other assertion messages in other tests down below.
https://nodejs.org/api/assert.html#assert_assert_strictequal_actual_expected_message
There was a problem hiding this comment.
Yeah, perhaps; I don't think it really matters, the main point is to clearly identify which assertion is throwing if you have an error. In any case, these are simply copied from tests earlier in the file, so if we want to fix this, it should be in a separate PR that fixes the entire file.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
fs.writevfs.opendir