port fix for mkdirp issue #111

[pabigot]

The original mkdirp mis-handles the fourth parameter when a directory
component is missing. The same issue is present in the fs-extra
variant.

See: https://github.com/substack/node-mkdirp/issues/111

[jprichardson]

Great, thanks. Please add a test.

[pabigot]

@jprichardson I'll probably do that but I'm going to wait until upstream decides what to do, since IMO variant behavior between fs-extras and mkdirp would be worse than both being wrong the same way.

[manidlou]

@jprichardson @RyanZim what is this one's destiny?!

[RyanZim]

Upstream mkdirp has never merged the patch, until then, I'm not merging it either.

[manidlou]

Upstream mkdirp has never merged the patch, until then, I'm not merging it either.

gotcha!

[pabigot]

FWIW, since upstream hasn't seen any updates since before this bug was reported I expect it to remain unmerged. At least it's logged in both places, and a fix is available for whoever really needs it.

[RyanZim]

Ah, wasn't aware of that. At fs-extra, we've never documented the made parameter AFAIK; I'm thinking we should just remove this undocumented feature in the next major release, especially since Node.js will be adding a recursive flag to fs.mkdir in a future release (nodejs/node#21875), and I'd like to use that for fse.mkdirp in environments that support it, and Node's method will not support the made parameter.

Edit: if we go this route; #359 can be closed.

[RyanZim]

@manidlou FYI, I have labeled this with feature-ensureDir, since that's an alias for mkdirs, and deleted the feature-mkdirs label.

[RyanZim]

Since we will be switching to Node's implementation in the future (#619), which does not support this parameter, we'll likely be removing it in the future. Upstream mkdirp has never patched this either. Closing this out.