Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chmod 666 is wrong #484

Closed
zengming00 opened this issue Sep 4, 2017 · 1 comment
Closed

chmod 666 is wrong #484

zengming00 opened this issue Sep 4, 2017 · 1 comment
Assignees
@RyanZim
Labels
bug feature-remove

Comments

@zengming00
Copy link

node-fs-extra/lib/remove/rimraf.js

Line 120 in ab2fae9

options.chmod(p, 666, er2 => {

use chmod 0o666
@RyanZim
Copy link
Collaborator

RyanZim commented Oct 18, 2017

Yep, good catch; sorry, this slipped through the cracks somehow. Relevant rimraf commit: isaacs/rimraf@38b907f

@RyanZim RyanZim self-assigned this Oct 18, 2017
RyanZim added a commit that referenced this issue Oct 18, 2017
@RyanZim
Use octal notation for chmod values in rimraf.js
ddb5cb4 
Backports isaacs/rimraf@38b907f
Fixes #484
@RyanZim RyanZim mentioned this issue Oct 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RyanZim RyanZim

Labels
bug feature-remove
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zengming00 @RyanZim