Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for statfs() and other newer fs functions in more recent versions of node.js #1044

Closed
Eric24 opened this issue Dec 19, 2024 · 3 comments · Fixed by #1045
Closed

Support for statfs() and other newer fs functions in more recent versions of node.js #1044

Eric24 opened this issue Dec 19, 2024 · 3 comments · Fixed by #1045
Labels
bug promises

Comments

@Eric24
Copy link

Eric24 commented Dec 19, 2024

Are newer fs functions "automatically" included in the promisified list of functions, or must these functions specifically be listed in the fs-extra source?
@RyanZim
Copy link
Collaborator

RyanZim commented Dec 19, 2024

Need to be listed in https://github.com/jprichardson/node-fs-extra/blob/master/lib/fs/index.js; PR welcome to add them.

RyanZim added a commit that referenced this issue Jan 10, 2025
@RyanZim
Add promise support for missing fs methods
89a1ae8 
Fixes #1044
@RyanZim RyanZim mentioned this issue Jan 10, 2025
Merged
@RyanZim
Copy link
Collaborator

RyanZim commented Jan 10, 2025

Finally got around to this myself: #1045

RyanZim added a commit that referenced this issue Jan 14, 2025
@RyanZim
Add promise support for missing fs methods (#1045)
e75b9bf 
* Add promise support for missing fs methods

Fixes #1044

* Try specifying macOS runner explicitly
@RyanZim
Copy link
Collaborator

RyanZim commented Jan 15, 2025

Fixed in fs-extra@11.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug promises
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add promise support for missing fs methods jprichardson/node-fs-extra
2 participants
@Eric24 @RyanZim