Fix tests on Node 14 (#800)

* Fix tests on Node 14 Fixes #798 writeFileSync requires a data parameter * Add Node 14 to CI
jprichardson · May 14, 2020 · 28173ed · 28173ed
1 parent 957e1c3
commit 28173ed
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -7,6 +7,7 @@ node_js:
   - 11
   - 12
   - 13
+  - 14
 env: TEST_SUITE=unit
 matrix:
   exclude:

diff --git a/appveyor.yml b/appveyor.yml
@@ -4,7 +4,7 @@ environment:
     # node.js
     - nodejs_version: "10"
     - nodejs_version: "12"
-
+    - nodejs_version: "14"
 # Install scripts. (runs after repo cloning)
 install:
   # Get the latest stable version of Node.js or io.js

diff --git a/lib/ensure/__tests__/create.test.js b/lib/ensure/__tests__/create.test.js
@@ -46,7 +46,7 @@ describe('fs-extra', () => {
       it('should give clear error if node in directory tree is a file', done => {
         const existingFile = path.join(TEST_DIR, Math.random() + 'ts-e', Math.random() + '.txt')
         fse.mkdirsSync(path.dirname(existingFile))
-        fs.writeFileSync(existingFile)
+        fs.writeFileSync(existingFile, '')
 
         const file = path.join(existingFile, Math.random() + '.txt')
         fse.createFile(file, err => {
@@ -79,7 +79,7 @@ describe('fs-extra', () => {
       it('should give clear error if node in directory tree is a file', () => {
         const existingFile = path.join(TEST_DIR, Math.random() + 'ts-e', Math.random() + '.txt')
         fse.mkdirsSync(path.dirname(existingFile))
-        fs.writeFileSync(existingFile)
+        fs.writeFileSync(existingFile, '')
 
         const file = path.join(existingFile, Math.random() + '.txt')
         try {

diff --git a/lib/remove/__tests__/remove.test.js b/lib/remove/__tests__/remove.test.js
@@ -21,7 +21,7 @@ function buildFixtureDir () {
 
   const subDir = path.join(TEST_DIR, Math.random() + '')
   fs.mkdirSync(subDir)
-  fs.writeFileSync(path.join(subDir, Math.random() + ''))
+  fs.writeFileSync(path.join(subDir, Math.random() + ''), buf)
   return baseDir
 }