Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added field 19 #20

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Added field 19 #20

merged 1 commit into from
Oct 13, 2022

Conversation

rainer010
Copy link
Contributor

This field contains the code identifying the country of the acquiring institution.

This field contains the code identifying the country of the acquiring
institution.
@rainer010
Copy link
Contributor Author

I checked the ISO-8583 v2003 documentation and the field 19 is not defined. On the other hand, both major card schemes use this field for the same purpose with the same semantic. Hence, I thought it might be good to leave it there.

What do you think ? @ar

@rainer010
Copy link
Contributor Author

The same reasoning could be applied to the PR #13

@alcarraz
Copy link
Contributor

I checked the ISO-8583 v2003 documentation and the field 19 is not defined. On the other hand, both major card schemes use this field for the same purpose with the same semantic. Hence, I thought it might be good to leave it there.

I see DE 19 as Country code acquiring institution in ISO8583 v2003, in table B.1.

@alcarraz
Copy link
Contributor

I see DE 19 as Country code acquiring institution in ISO8583 v2003, in table B.1.

So IMHO it is ok to add them, same goes for DE's 009 and 010 of #13, in fact that PR was from the ISO 8583 v2003 spec.

@rainer010
Copy link
Contributor Author

I see DE 19 as Country code acquiring institution in ISO8583 v2003, in table B.1.

So IMHO it is ok to add them, same goes for DE's 009 and 010 of #13, in fact that PR was from the ISO 8583 v2003 spec.

You are right, to summarize the related PRs:

field Location in standard spec PR
9 Table 3.1, page 22 #13
10 Table 3.1, page 22 #13
19 Table 3.1, page 22 #20

I agree with you, these fields should be added.

@ar ar merged commit 41d040b into jpos:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants