Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Node 14 Support & add Node 20 & switch to es2017 #2370

Merged
merged 4 commits into from
May 3, 2023
Merged

Deprecate Node 14 Support & add Node 20 & switch to es2017 #2370

merged 4 commits into from
May 3, 2023

Conversation

AlbertoBrusa
Copy link
Contributor

@AlbertoBrusa AlbertoBrusa commented May 3, 2023 •
edited
Loading

  • Remove Node 14 from tests
  • Add Node 20 to tests
  • Remove Node 14 from engines
  • Add Node 20 to engines
  • Remove Node 14 from docs
  • Add Node 20 to docs
  • Switch target to ES2017 from ES2016

@changeset-bot
Copy link

changeset-bot bot commented May 3, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: beca452

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
create-modular-react-app Major
eslint-config-modular-app Major
modular-scripts Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AlbertoBrusa AlbertoBrusa changed the title Deprecate Node 14 Support Deprecate Node 14 Support & add Node 20 May 3, 2023
@AlbertoBrusa AlbertoBrusa changed the title Deprecate Node 14 Support & add Node 20 Deprecate Node 14 Support & add Node 20 & switch to es2017 May 3, 2023
@coveralls
Copy link
Collaborator

coveralls commented May 3, 2023 •
edited
Loading

Coverage Status

Coverage: 43.964% (-5.7%) from 49.631% when pulling beca452 on AlbertoBrusa:rm-node-14 into 3cea60b on jpmorganchase:feature/v5.0.

@AlbertoBrusa AlbertoBrusa marked this pull request as ready for review May 3, 2023 12:24
@AlbertoBrusa AlbertoBrusa merged commit ef63eb3 into jpmorganchase:feature/v5.0 May 3, 2023
@AlbertoBrusa AlbertoBrusa deleted the rm-node-14 branch May 3, 2023 12:51
@github-actions github-actions bot mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristiano-belloni cristiano-belloni cristiano-belloni approved these changes

@ayseenver ayseenver ayseenver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlbertoBrusa @coveralls @cristiano-belloni @ayseenver