Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint imports #2369

Merged
merged 11 commits into from
May 3, 2023
Merged

Conversation

AlbertoBrusa
Copy link
Contributor

@AlbertoBrusa AlbertoBrusa commented May 2, 2023

  • Added a 'recommended' eslint configuration that extends our base eslint configuration and adds import sorting
  • Added said configuration as default for CMRA & our templates
  • Added documentation on how to use the new configuration in existing projects

Still to do:

  • Run lint --fix to get tests passing

@changeset-bot
Copy link

changeset-bot bot commented May 2, 2023

🦋 Changeset detected

Latest commit: bc93527

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
modular-template-app Major
modular-template-esm-view Major
modular-template-package Major
modular-template-source Major
modular-template-view Major
create-modular-react-app Minor
eslint-config-modular-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AlbertoBrusa AlbertoBrusa marked this pull request as ready for review May 3, 2023 09:11
@coveralls
Copy link
Collaborator

coveralls commented May 3, 2023

Coverage Status

Coverage: 49.582% (-0.05%) from 49.634% when pulling bc93527 on AlbertoBrusa:lint-imports into 3cea60b on jpmorganchase:feature/v4.4.

@AlbertoBrusa AlbertoBrusa merged commit 3141f92 into jpmorganchase:feature/v4.4 May 3, 2023
@AlbertoBrusa AlbertoBrusa deleted the lint-imports branch May 3, 2023 13:24
@github-actions github-actions bot mentioned this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants