Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove modular-template dependencies after modular add #2365

Merged

Conversation

AlbertoBrusa
Copy link
Contributor

@AlbertoBrusa AlbertoBrusa commented Apr 27, 2023

Still to do:

  • Fix for tests (when we added the template without it being in the package.json

@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023

🦋 Changeset detected

Latest commit: 7036d48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
modular-scripts Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AlbertoBrusa AlbertoBrusa changed the base branch from main to feature/v4.4 April 27, 2023 12:43
@AlbertoBrusa AlbertoBrusa marked this pull request as ready for review April 27, 2023 12:43
@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 43.831% (-0.01%) from 43.846% when pulling 7036d48 on AlbertoBrusa:cleanup-templates into d770c80 on jpmorganchase:feature/v4.4.

@AlbertoBrusa AlbertoBrusa merged commit 89097fc into jpmorganchase:feature/v4.4 Apr 27, 2023
@AlbertoBrusa AlbertoBrusa deleted the cleanup-templates branch April 27, 2023 14:33
@github-actions github-actions bot mentioned this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants