Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inherit package.json's engines field when building #2364

Merged
merged 4 commits into from
Apr 28, 2023
Merged

Inherit package.json's engines field when building #2364

merged 4 commits into from
Apr 28, 2023

Conversation

AlbertoBrusa
Copy link
Contributor

@AlbertoBrusa AlbertoBrusa commented Apr 27, 2023 •
edited
Loading

  • Inherit engines filed from workspace's package.json when building a package/app/esm-view/view
  • Use the root's package.json's engines field if not specified in workspace
  • Update test snapshots

@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 0c433d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
modular-scripts Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link
Collaborator

coveralls commented Apr 27, 2023 •
edited
Loading

Coverage Status

Coverage: 43.897% (+0.02%) from 43.872% when pulling 0c433d9 on AlbertoBrusa:engines into ccffbfd on jpmorganchase:feature/v4.4.

@AlbertoBrusa AlbertoBrusa marked this pull request as ready for review April 27, 2023 12:13
@AlbertoBrusa AlbertoBrusa merged commit fdf2f71 into jpmorganchase:feature/v4.4 Apr 28, 2023
@github-actions github-actions bot mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveukx steveukx steveukx left review comments

@sgb-io sgb-io sgb-io approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlbertoBrusa @coveralls @steveukx @sgb-io