Enable "strict" compiler option #2352
Conversation
🦋 Changeset detectedLatest commit: 4761d53 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -55,7 +61,7 @@ function restrictUserTsconfig( | |||
|
|
|||
| // Where the user has defined allowlist-supported compiler options, apply them | |||
| for (const item of COMPILER_OPTIONS_ALLOW_LIST) { | |||
| if (compilerOptions && compilerOptions[item]) { | |||
| if (compilerOptions?.[item] !== undefined) { | |||
There was a problem hiding this comment.
nit: I get that this is needed to allow false, but by explicitly checking for !== undefined I think you might be technically allowing something like null. Saying that, it's probably OK to consider that something end users should fix though, rather than validating values here or anything.
There was a problem hiding this comment.
@sgb-io I guess if we end up with null there, it means that the user explicitly (and probably erroneously) ended up with a null option in their configuration. I think we should let tsconfig validate and eventually throw in that case, instead of ignoring the option, because it could be a symptom of something wrong (i.e. buggy conf script / json from the user). undefined is a special case, because unfortunately it means both "absence of key" and "key was set to undefined" in Javascript, and there's no way of distinguishing that if the conf comes from outside.
strict