-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/v4.2 #2324
Merged
Merged
Feature/v4.2 #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Artificially use all packages if no packages is specified * Filter out everything non-modular * Re-instate cleaning regexes * Factor out function to partition testable packages * Style fixes * Make Modular a source type in order to test it * Update snapshot * Run non-modular tests * CMRA is a source * Remove source type * Update snapshots * Remove unneeded quotes * Add tests for unobtrusive modular * Remove test * Update jest * Write new test docs * Add jsdoc and remove logs * remove final logs * Improve docs for test * Remove console.log
… into feature/v4.2
* Move out synth index function * Restrict only to esbuild * Only write index if esbuild or esm-view * Introduce hasIndex * Actually use public/index.html in esm-views * factor out function that writes index.html * Factor out trampoline generator * Factor out function that creates minified html for the index * Revert "Factor out function that creates minified html for the index" This reverts commit 449338d. * Remove unused functions * Simplify createStartIndex * Rename function * Test custom index in esm-views * Factor out buildStandalone * Remove dynamic import * Documentation for esm-view index.html * Write jsdocs for writeOutputIndexFiles * Webpack configuration to support custom index with esm-view start * Create new-pans-tell.md * Update package type table * Move head into html * Remove log * Fix table
* Copy assets for esm-views * Only copy public if the directory exists * Better logs * Create cyan-peaches-visit.md * Fix comment
* Move react-scripts & webpack-dev-server scripts into modular-scripts/src * Restructure react-scripts & webpack-dev-server & esbuild-scripts into more consistent folder structures * Translate to TS webpack.config.js and most supporting scripts * Deduplicate scripts shared between webpack and esbuild * Rename createPaths to determineTargetPaths to more accurately reflect functionality * Enhance determineTargetPaths to include now deleted/deduplicated paths.js functionality * Add all feature branches to github actions * Update test snapshots * Merge esbuild-https-certs-support - authored-by: Sam Brown <sam.brown@jpmorgan.com>
🦋 Changeset detectedLatest commit: 2c25504 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sgb-io
approved these changes
Mar 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.