Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid including actual version numbers in workspaceInfo test #2303

Conversation

sgb-io
Copy link
Contributor

@sgb-io sgb-io commented Mar 3, 2023

Although this snapshot is no longer affected by OS-subjected ordering of directories, it was including the actual current version of packages, which gets in the way during the release process.

This change retains a simple snapshot solution that doesn't depend on ordering, but removes the version strings from the snapshot comparison

@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2023

⚠️ No Changeset found

Latest commit: 850f78c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 26.915% (+0.02%) from 26.894% when pulling 850f78c on sgb-io:fix/avoid-versions-in-workspace-test into 25f5902 on jpmorganchase:main.

@cristiano-belloni cristiano-belloni merged commit 348da35 into jpmorganchase:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants