New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject pyopenssl into urllib3 only when necessary #292

Open

zkonge wants to merge 1 commit into jplana:master from zkonge:master

zkonge commented Aug 26, 2024

The code is copied from latest requests https://github.com/psf/requests/blob/a3ce6f007597f14029e6b6f54676c34196aa050e/src/requests/__init__.py#L124

Follow upstream Don't use pyOpenSSL unless no SNI is detected psf/requests#5443 and requests[security] / PyOpenSSL does not make requests more secure but more brittle psf/requests#5267
New PyOpenSSL bundles the OpenSSL 3, which may cause performance degradation OpenSSL 3.0 performance issue: SSLContext.set_default_verify_paths / load_verify_locations about 5x slower python/cpython#95031, especially in old Python that uses OpenSSL 1.1-, because urllib3 prefer PyOpenSSL after injecting.


          Inject pyopenssl into urllib3 only when necessary

876d8f1

loveyana commented Sep 4, 2024

@lavagetto Would you mind taking a look at this PR when you have a moment? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet