-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean merge of fixed mysql datetime handling #440
Conversation
bdf04cc
to
e3abc3a
Compare
439a27d
to
9b50fa8
Compare
There are so many commits from so many authors with over 80 files and over 3400 lines changed here, with a lot of the changes seemingly just formatting. Reviewing this is nearly impossible. |
9b50fa8
to
e1f3584
Compare
Rebased, should be readable now |
e1f3584
to
0d7b69d
Compare
I've left out the commits with the patch for now, to show that tests are not failing without them, |
Hmm, yea, weird that the tests still pass. |
0d7b69d
to
85ace01
Compare
@koenpunt I think I know why these tests were passing. I believe that Travis-CI changed their mysql configuration, so that We should add |
💥 ❗ So, yea, like I thought, the Travis MySQL environment changed recently which hid the bug away. Turning on a strict |
Rebased version of #317