Bug Fix - Association Guarded Attributes

[Rican7]

This fixes the association builder, so that you can build associated models without having to make the associated foreign_keys accessible to "mass assigning" (not something that you'd normally want to allow).

Example

<?php

class User extends Model
{
    static $has_many = array(
        array('emails'),
    );
}

/**
 * Email has three fields:
 * 'id', 'user_id', and 'email'
 */
class Email extends Model
{
    static $belongs_to = array(
        array('user'),
    );

    // Don't allow access to mass-set
    // our "id" or "user_id" attributes
    static $attr_accessible = array(
        'email',
    );
}

$user = User::find(1);
$user->create_email(array(
    'email' => 'example@example.com',
));
// FAILS

This Fails

THIS FAILS, with a foreign key exception, as the "create_email" method try's to set the foreign key of the model with "guard_attributes" set to true.

[Rican7]

Whoops. I accidentally closed this earlier. Re-opening...

[Rican7]

I rebased off of the new master, so I could have Travis test with our new test-db, and all related tests passed.
It's still showing a fail, however, since there are other Travis bugs that currently exist (the find_by_datetime one #298).

I'd say this is safe to merge, but I'll wait for @al-the-x and @jpfuentes2 to weigh in.

[al-the-x]

Since this is related to the feature you've outlined in #287, maybe we should slate this for 1.2+ as well?

[Rican7]

We could, but it affects anyone that uses $attr_protected and/or $attr_accessible, regardless of the security default in #287. This also doesn't break BC.

[al-the-x]

@Rican7, can you rebase on "master" and force-push to flatten the history before we merge this? I think this is probably the next safe candidate for merge.

[Rican7]

@al-the-x You want me to squash 2 commits that change 2 different files? Or just rebase off of master for the new testing?

I really should include tests in this fix, actually..

[Rican7]

@al-the-x @jpfuentes2 any reason to not click the green button?

[al-the-x]

Tests would be great. Squashes are appreciated. ;)

[Rican7]

Ohhhhhh yea. I forgot that I said I was gonna write tests.
#mybad

[Rican7]

Tests added. And they pass. :)
If you'd like to be extra thorough, try running the same tests without the fix in this PR, and they will fail.

In other words, this fixes the bug. :P

❓

[Rican7]

This delay, man. Its killing me. @al-the-x @jpfuentes2

[jpfuentes2]

I will hit the green button, but only because of:

If you'd like to be extra thorough, try running the same tests without the fix in this PR, and they will fail.
In other words, this fixes the bug. :P

💤

[Rican7]

Haha. Thank you sir!