Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace .Site.IsMultiLingual with hugo.IsMultilingual #921

Merged
merged 2 commits into from
Oct 6, 2024

Conversation

jneidel
Copy link
Contributor

@jneidel jneidel commented Aug 25, 2024

Addresses this deprecation warning:

WARN  deprecated: .Site.IsMultiLingual was deprecated in Hugo v0.124.0 and will be removed in a future release. Use hugo.IsMultilingual instead.

hugo.IsMultilingual was introduced in v0.124.0.
So merging this PR would effectively make that the minimum required version. (See failing pipelines on initial commit, which are only using v0.119.)
Maybe you want to hold off on merging this for the time being 😄

Copy link

netlify bot commented Aug 25, 2024

Deploy Preview for hugo-congo ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2125f69
🔍 Latest deploy log https://app.netlify.com/sites/hugo-congo/deploys/66cb12cefd4a7100086d698a
😎 Deploy Preview https://deploy-preview-921--hugo-congo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jpanther
Copy link
Owner

jpanther commented Oct 6, 2024

Thanks for the PR. I've held off on merging this for a little while as I don't want to force people to have to bump their Hugo versions unnecessarily but it's been out for 6 months now which I think is a reasonable time for people to update their dependencies. I'll merge this in and update the theme minimum Hugo version to v0.124.0.

@jpanther jpanther added the bug Something isn't working label Oct 6, 2024
@jpanther jpanther merged commit 8e58306 into jpanther:dev Oct 6, 2024
6 checks passed
This was referenced Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants