-
-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed jwt CLI script to jwt-cli to avoid issues with jwt script overlapping with the jwt package. #187
Conversation
c6b7077
to
9c835e2
Compare
@mark-adams would this be a breaking change? People would be running |
Great point! Yes, this would be a breaking change. People would run I just updated the CHANGELOG to reflect this as well. |
@jpadilla I wanted to clarify one more time before I merged this... are you ok with this rename? |
TBH I don't really like adding |
c18d17c
to
623999b
Compare
…rlapping with the jwt package. Fixes #130
3c6bede
to
5c5fab1
Compare
1 similar comment
@jpadilla Done! Renamed jwt-cli -> pyjwt |
@mark-adams sweet, thanks! Should we put out a new release? |
So, instead of getting rid of the jwt CLI script as we discussed in #130, what do you think about just renaming it to jwt-cli so that it doesn't overlap with
jwt
anymore? That should pretty much fix any outstanding issues.Thoughts @jpadilla?