Copy tls.crt to ca.crt always unless ca.crt exists #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the init container only copied tls.crt to ca.crt after generating a new certificate. When using cert-manager with an ACME issuer to generate a certificate, the resulting secret will also not have a ca.crt. When doing the copy like this, both cases would be covered without impacting other cases.
|
This in combination with reloader allows me to use letsencrypt via cert-manager. |
|
@jp-gouin tagging you just in case your notification setup is similar to mine. |
|
Hi @pschichtel Thanks for the PR! |
|
looks like CI is broken due to a broken ubuntu mirror |
|
Yeah looks like it , please bear with me , I'm a bit off at the moment but I'll look into it end of month |
|
@jp-gouin you can take a look at a workflow I made. Looking to get this feature as well https://github.com/invoiceninja/dockerfiles/blob/master/.github/workflows/test-charts.yaml These are good to have:
You can extend |
lwj5
reviewed
Aug 29, 2023
Co-authored-by: Ween Jiann <16207788+lwj5@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the init container only copied tls.crt to ca.crt after generating a new certificate. When using cert-manager with an ACME issuer to generate a certificate, the resulting secret will also not have a ca.crt. When doing the copy like this, both cases would be covered without impacting other cases.