Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Error during build #226

Closed
hecon5 opened this issue May 20, 2021 · 10 comments
Closed

Getting Error during build #226

hecon5 opened this issue May 20, 2021 · 10 comments

Comments

@hecon5
Copy link
Contributor

hecon5 commented May 20, 2021

I'm getting an intermittent unhandled error during build from Vb project; I think it's related to the helpfile parsing. If I step through the first part of the build, it works fine; if not, I get an unhandled exception "somewhere". Trying to figure out more.

Excerpted Log:


Beginning Build from Source
[Redacted]
VCS Version 3.3.35
5/20/2021 12:12:53 PM


Importing vb project...
vbe-project.json


ERROR: Unhandled error found before On Error directive

Error 440: Automation error Source: Unknown
[1] vb project processed.

@hecon5
Copy link
Contributor Author

hecon5 commented Jun 17, 2021

Still attempting to troubleshoot this; I think it happens around the location of the SafeSetProperty. If I step through at least the VBE-Project, it will import just fine.

@hecon5
Copy link
Contributor Author

hecon5 commented Jun 17, 2021

Added CatchAny eelError, "Setting Property:" & strProperty & ", Value:" & CStr(varValue), ModuleName & ".SafeSetProperty" to SafeSetProperty at the end; and with the testing database it reveals that some values are throwing errors which aren't cleared later. I think they're related to RD's use of the HelpContextID

@hecon5
Copy link
Contributor Author

hecon5 commented Jun 17, 2021

If for some reason help context ID was a non-zero number, it'll pass muster, but I still cannot set it in my environment. Clearing the error helps, and debugs it, but it won't set (for me).

-------------------------------------
ERROR: Setting Property:HelpContextId, Value:123456
-------------------------------------
Error 440: Automation error Source: clsDbVbeProject.SafeSetProperty

joyfullservice added a commit that referenced this issue Jun 17, 2021
If we are updating an existing project, we might need to set the HelpContextID back to 0, for example. This change ensures that the property is set to the desired value, even if the desired value is 0 or an empty string. See #226
@joyfullservice
Copy link
Owner

@hecon5 - I made some additional changes to the VBE property import functions. Can you verify that this still works correctly for you?

@joyfullservice joyfullservice added this to the Release 3.4.0 milestone Jun 17, 2021
@hecon5
Copy link
Contributor Author

hecon5 commented Jun 21, 2021

This appears to function; I haven't been getting the error, but I'll keep my eye on it.

@hecon5 hecon5 closed this as completed Jun 21, 2021
@hecon5
Copy link
Contributor Author

hecon5 commented Jul 12, 2021

So, I'm getting this error again with the latest 3.4.11 on the testing database; it does work, however (eg, I get an error and I shouldn't be, because the value is set correctly).

@hecon5 hecon5 reopened this Jul 12, 2021
@joyfullservice
Copy link
Owner

Where are we at on this one? It looks like it is currently the last issue tied to the 3.4.x milestone... Is this something that could be easily reproducible?

@hecon5
Copy link
Contributor Author

hecon5 commented Jul 19, 2021

I get it intermittently on the testing database. The error itself is a false positive; it definitely sets the value, just throws an error also (at least...seems to).

@hecon5
Copy link
Contributor Author

hecon5 commented Jul 19, 2021

To be clear; I think this should be bumped to the next version. It's a nuisance, but doesn't break anything.

@joyfullservice joyfullservice removed this from the Release 3.4.0 milestone Jul 19, 2021
@joyfullservice
Copy link
Owner

Taking a look at the code again, it looks like this was a simple logic error. If the property is successfully set, any corresponding error should be discarded before reaching the final error handler. (As long as the value was correctly set, we are not too concerned about an error thrown in the process.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants