Implement recursive fs watch on Windows #1473
Conversation
| @@ -626,6 +626,7 @@ RB_HEAD(uv_timer_tree_s, uv_timer_s); | |||
| HANDLE dir_handle; \ | |||
| int req_pending; \ | |||
| uv_fs_event_cb cb; \ | |||
| unsigned int win_flags; \ | |||
There was a problem hiding this comment.
Call it fs_flags, this code in on the Windows side anyway.
|
Thanks! Could you please add a test for this? |
ghostoy
force-pushed
the
recursive-watch-win
branch
from
f7f5180 to
37c44fb
Compare
ghostoy
force-pushed
the
recursive-watch-win
branch
from
37c44fb to
722620e
Compare
|
@saghul Already done. |
|
Thanks! I'll take a look. |
|
Thanks, this would be really helpful. |
|
👍 |
|
Any plan to merge this PR? |
|
Plans, yes, time, not so much lately, but it will! :-) On Thu, Nov 6, 2014 at 9:26 AM, Cong Liu notifications@github.com wrote:
/Saúl |
|
Would be great to have this landed soon. There is already recursive watch support on OS X and Linux can use per-directory watchers. But Windows can't just use multiple watchers as this would lock each watched directory (i.e. preventing the user from renaming those directories etc.). This is the last thing stopping a decent cross-platform watch implementation. |
|
Ouch, looks like this fell through the cracks :-( It will need a bit of adjustment, because as it stands it breaks the ABI, but we can probably use one of the reserved fields. |
Original patch by @ghostoy, modified by @bpasero and yours truly. Refs: joyent/libuv#1473 Refs: libuv#198
|
Superseded by libuv/libuv#421 |
Original patch by @ghostoy, modified by @bpasero and yours truly. Refs: joyent/libuv#1473 Refs: libuv#198 PR-URL: libuv#421 Reviewed-By: Bert Belder <bertbelder@gmail.com>
Original patch by @ghostoy, modified by @bpasero and yours truly. Refs: joyent/libuv#1473 Refs: #198 PR-URL: #421 Reviewed-By: Bert Belder <bertbelder@gmail.com>
Original patch by @ghostoy, modified by @bpasero and yours truly. Refs: joyent/libuv#1473 Refs: libuv#198 PR-URL: libuv#421 Reviewed-By: Bert Belder <bertbelder@gmail.com>
Original patch by @ghostoy, modified by @bpasero and yours truly. Refs: joyent/libuv#1473 Refs: libuv#198 PR-URL: libuv#421 Reviewed-By: Bert Belder <bertbelder@gmail.com>
No description provided.