Skip to content

MacOS arm64 support #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 13, 2021
Merged

MacOS arm64 support #90

merged 11 commits into from
Dec 13, 2021

Conversation

rkistner
Copy link
Member

@rkistner rkistner commented Dec 9, 2021 •
edited
Loading

  1. Pre-built binaries for arm64 by cross-compiling to fix cannot download precompiled napi (macos arm64) #87.
  2. Remove Python build dependency to fix builds on Windows.
  3. Rename VERSION -> VERSION.txt to fix Install on macOS failing with error: unexpected unqualified-id #83.
  4. Include dependencies directly in the repo, instead of in a tarball.
  5. Exclude build dependencies from the package, and disable the default --fallback-to-build.

@rkistner rkistner mentioned this pull request Dec 9, 2021
Merged
@rkistner rkistner merged commit e31020d into master Dec 13, 2021
@rkistner rkistner deleted the macos-arm64 branch December 13, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@julienvincent julienvincent julienvincent approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot download precompiled napi (macos arm64) Install on macOS failing with error: unexpected unqualified-id
2 participants
@rkistner @julienvincent