New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notes on electron-forge #64

Merged

rkistner merged 1 commit into master from update-docs-electron

Jan 13, 2021

Member

rkistner commented Jan 12, 2021 •

edited

Loading

There are multiple issues with electron-forge / electron-builder attempting to rebuild this module.

It does not support {napi_build_version} in the module_path. See Incorrect folder name when rebuilding "sqlite3" for arm64/x64 architecture electron/rebuild#554 / Cannot rebuild sqlite3 electron/rebuild#546.
It does not use the pre-built modules. See node-pre-gyp support in the same way than prebuild is supported electron/rebuild#367.
When building from source, there is something wrong in the build environment causing a compile error (Build fails on Windows with Electron 11: 'napi_is_detached_arraybuffer': identifier not found #63).

The workaround is to not attempt to rebuild the this module, since it's not required.

Fixes #53 #54 #56 #61 #63.

Supersedes #60.


          Add notes on electron-forge.

rkistner mentioned this pull request

fix for windows build for node-sqlcipher 5.0.0 #60

Closed

johnshearar approved these changes

View reviewed changes

rkistner merged commit 1a4523a into master

rkistner deleted the update-docs-electron branch

January 13, 2021 06:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet