Update package.json #164
Update package.json #164
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| @@ -164,7 +164,7 @@ | |||
| "webpack": "^5.93.0" | |||
| }, | |||
| "peerDependencies": { | |||
| "react": ">=17.0.0" | |||
| "react": ">=18.0.0" | |||
There was a problem hiding this comment.
Good catch! I think we want to be react 17 friendly for a short while.
Could you help us identify the hooks that rely on useId and help write a custom impl. that lives within our repo? (@Elvincth is helping us migrate away from @mantine/* so hopefully this shouldn't be a huge issue)
There was a problem hiding this comment.
I think a simpler approach would be to downgrade the version of @mantine/* to meet the requirements of react>=17. What do you think?
There was a problem hiding this comment.
Unfortunately, that is not an option, it'd require a lot more changes. Mantine v6 -> v7 was a breaking change. 😟
The react peerDependencies version should be greater than 18, as the react peerDependencies version for @mantine/hooks is above 18, and it internally uses
useIdthat does not exist in React 17