Skip to content

Commit

Permalink
fix: playback speed dropdown color
Browse files Browse the repository at this point in the history
  • Loading branch information
arjunvegda committed Apr 1, 2024
1 parent bb9351a commit 3fcc4dd
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 1 deletion.
3 changes: 3 additions & 0 deletions src/DevTools/DevTools.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import {
} from './atoms/devtools-options';
import { Extension, ExtensionProps } from './Extension';
import { InternalDevToolsContext } from './internal-jotai-store';

// TODO move these out to a separate entry point
import './styles.css';

export type DevToolsProps = ExtensionProps & {
Expand All @@ -20,6 +22,7 @@ export type DevToolsProps = ExtensionProps & {
options?: DevToolsOptions;
};

// TODO move the id to a common place as a const
const getRootElement = () => {
const value =
typeof window === 'undefined'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,15 @@ export const PlaybackSpeedDropdown = () => {
maw={80}
id="jotai-devtools-playback-speed-dropdown"
data-testid="jotai-devtools-playback-speed-dropdown"
comboboxProps={{ position: 'top', keepMounted: false, zIndex: 99999 }}
comboboxProps={{
position: 'top',
keepMounted: false,
withinPortal: false,
zIndex: 99999,
portalProps: {
target: `#jotai-devtools-root`,
},
}}
/>
);
};
1 change: 1 addition & 0 deletions src/DevTools/styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
font-size: var(--mantine-font-size-md);
}

/* TODO import more granular styles */
@import '@mantine/core/styles.css';
@import '@mantine/code-highlight/styles.css';
@import './fonts/fonts.css';

0 comments on commit 3fcc4dd

Please sign in to comment.