Add isMounted ref to suppress async state setter functions #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curt-tophatter
commented
Nov 21, 2020
| @@ -1753,7 +1753,7 @@ | |||
| resolved "https://registry.yarnpkg.com/@types/history/-/history-4.7.5.tgz#527d20ef68571a4af02ed74350164e7a67544860" | |||
| integrity sha512-wLD/Aq2VggCJXSjxEwrMafIP51Z+13H78nXIX0ABEuIGhmB5sNGbR113MOKo+yfw+RDo1ZU3DM6yfnnRF/+ouw== | |||
|
|
|||
| "@types/howler@^2.1.2": | |||
| "@types/howler@2.1.2": | |||
There was a problem hiding this comment.
This just came from running a yarn install fwiw
curt-tophatter
commented
Nov 21, 2020
| @@ -0,0 +1 @@ | |||
| 13.12 | |||
There was a problem hiding this comment.
I had to upgrade my node version to get yarn install to pass as per nodejs/node#32852 (comment)
joshwcomeau
approved these changes
Nov 24, 2020
|
🙌 |
|
Looks good! Published under 2.0.1. RE: The hooks warning in your screenshot, I'm guessing that's the really-annoying issue with Yarn/NPM link. I've dealt with that in the past, but I forget how 😬 I think by linking React/ReactDOM as well? I test this project exclusively in the contained storybook. Thanks again =) |
|
Can't thank you enough for your time merging and publishing this! |
|
It is still there, isn't it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@joshwcomeau I think this is what you were getting at. I'm having a hell of a time trying to test this locally though, due the following error:
Fixes #14