Skip to content

Commit

Permalink
Minor left nav fixes (opensearch-project#368)
Browse files Browse the repository at this point in the history
* Fix operation panel create link

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Rename panels header to dashboard

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Fix cancel url under applications

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

---------

Signed-off-by: Rupal Mahajan <maharup@amazon.com>
  • Loading branch information
rupal-bq authored and joshuali925 committed Apr 18, 2023
1 parent 85d5470 commit a428a23
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
8 changes: 6 additions & 2 deletions public/components/application_analytics/components/create.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,11 @@ import {
OptionType,
} from '../../../../common/types/application_analytics';
import { fetchAppById } from '../helpers/utils';
import { observabilityID, observabilityTitle } from '../../../../common/constants/shared';
import {
observabilityApplicationsID,
observabilityID,
observabilityTitle,
} from '../../../../common/constants/shared';

interface CreateAppProps extends AppAnalyticsComponentDeps {
dslService: DSLService;
Expand Down Expand Up @@ -173,7 +177,7 @@ export const CreateApp = (props: CreateAppProps) => {

const onCancel = () => {
clearStorage();
window.location.assign(`${last(parentBreadcrumbs)!.href}application_analytics`);
window.location.assign(`${observabilityApplicationsID}#/`);
};

return (
Expand Down
10 changes: 3 additions & 7 deletions public/components/custom_panels/custom_panel_table.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ export const CustomPanelTable = ({
<EuiPageHeader>
<EuiPageHeaderSection>
<EuiTitle size="l">
<h1>Operational panels</h1>
<h1>Observability dashboards</h1>
</EuiTitle>
</EuiPageHeaderSection>
</EuiPageHeader>
Expand Down Expand Up @@ -344,11 +344,7 @@ export const CustomPanelTable = ({
</EuiPopover>
</EuiFlexItem>
<EuiFlexItem>
<EuiButton
fill
href="#/operational_panels/create"
data-test-subj="customPanels__createNewPanels"
>
<EuiButton fill href="#/create" data-test-subj="customPanels__createNewPanels">
Create panel
</EuiButton>
</EuiFlexItem>
Expand Down Expand Up @@ -413,7 +409,7 @@ export const CustomPanelTable = ({
<EuiButton
data-test-subj="customPanels__emptyCreateNewPanels"
fullWidth={false}
href="#/operational_panels/create"
href="#/create"
>
Create panel
</EuiButton>
Expand Down

0 comments on commit a428a23

Please sign in to comment.