Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade repo #51

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

jeanbmar
Copy link

@jeanbmar jeanbmar commented Feb 29, 2024

The repo is currently broken, this MR fixes it:

  • Upgrade all dependencies
  • Upgrade project structure to comply with Poetry expectations
  • Manage all dependencies through Poetry and get rid of requirements.txt
  • Manage gpt-migrate execution through Poetry as well using poetry run gpt-migrate
  • Use relative path for internal file reading
  • Add a maxtokens options to allow models using only 4096 tokens
  • Prevent gpt-migrate from crashing when model response content contains Python None
  • Prevent gpt-migrate from crashing when the project to convert contains nested directories
  • Use openai models by default

@donfn
Copy link

donfn commented May 19, 2024

Your PR seems to work, thanks a lot!
Although I'm not quite familiar with poetry, I had to mv ./src/gpt_migrate/ ./gpt_migrate, because it wouldn't recognize gpt-migrate as an internal package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants