Add getCurrentIpAddress action

[bachya]

Checks

• I've checked there are no linting errors.
• I've checked the code is still at 100% test coverage.

Added Actions (if relevant)

• Get Current IP Address

Are you happy to be listed as a contributor on Shortcuts.fun?

Yes

Any other information / comments

This is my first foray into Node and TypeScript – ever (after 10 years of Python). After I got my feet under me, your guides worked great.

Overall, I'm still getting used to the architecture of a Node module, how TypeScript is managed, etc., so it's entirely possible I haven't done things elegantly. Please send any feedback my way; I plan on contributing a lot! 😎

[joshfarrant]

Hey @bachya 👋 Great to have you as a contributor!

This is a good-looking PR, thanks!

To say this is your first foray into Node and Typescript this is excellent, and the code you've written is perfect. The only thing I'd ask would be to add two more tests to getCurrentIpAddress.spec.ts, something like:

builds a getCurrentIpAddress action when an address is passed

and

builds a getCurrentIpAddress action when a type is passed

The tests will pass in either an address or type to the getCurrentIpAddress function and then check that the output matches what we'd expect. You can essentially copy this test in setTorch.spec.ts, but just change the setting to address in the first test and type in the second. Other than that the PR is good to go!

Hope that makes sense. If you run into any issues let me know and I'd be happy to help 👍

[joshfarrant]

Just spotted a couple of very minor things.

[xAlien95]

@joshfarrant, should runScriptOverSSH be renamed to runScriptOverSsh?

Time ago I asked to use SSH instead of Ssh to follow how some JS functions/properties are named (e.g. .innerHTML), without noticing that in the CONTRIBUTING section is expressly written to use camelCase:

The file (and action) you're creating should be the name of the action as it appears in the Shortcuts app, camelCased.

[joshfarrant]

@xAlien95 I suppose we need to formally come down on one side or the other, and update the CONTRIBUTING.md to reflect that.

Take a look at #26

[joshfarrant]

Don't worry about the changes to casing mentioned in the previous two comments btw @bachya, we'll sort that out at a later point once a decision's been made in #26.

[joshfarrant]

Looking good!