Skip to content

Commit

Permalink
Use define instead of #![deny(warning)] (#1290)
Browse files Browse the repository at this point in the history
Setting #![deny(warnings) in the source can cause josh
fail to build on different versions of rustc.
This way we only ensure there are no warnings on our
"officially supported" rustc version, but allow building
on other versions as well.

Change: warnings
  • Loading branch information
christian-schilling authored Nov 4, 2023
1 parent 465dd8f commit 7b8259b
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ on:

env:
CARGO_TERM_COLOR: always
RUSTFLFAGS: "-D warnings"

jobs:
build:
Expand Down
1 change: 0 additions & 1 deletion josh-filter/src/bin/josh-filter.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#![deny(warnings)]
#![warn(unused_extern_crates)]

#[macro_use]
Expand Down
1 change: 0 additions & 1 deletion josh-proxy/src/bin/josh-proxy.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#![deny(warnings)]
#[macro_use]
extern crate lazy_static;
extern crate clap;
Expand Down
1 change: 1 addition & 0 deletions tester.sh
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ if [[ ! -v CARGO_TARGET_DIR ]]; then
exit 1
fi
export RUSTFLFAGS="-D warnings"
cargo build --workspace --exclude josh-ui --features hyper_cgi/test-server
( cd josh-ssh-dev-server ; go build -o "\${CARGO_TARGET_DIR}/josh-ssh-dev-server" )
sh run-tests.sh ${TESTS}
Expand Down

0 comments on commit 7b8259b

Please sign in to comment.