Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: Refactor Overlay; Add Popover and Backdrop components #263

Merged
merged 7 commits into from
Feb 13, 2024
Merged

breaking: Refactor Overlay; Add Popover and Backdrop components #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
99f1da8
breaking: Refactor Overlay; Add Popover and Backdrop components
josemarluedke Feb 10, 2024
75b1226
chore: refactor dropdown to use Popover; fix tests
josemarluedke Feb 11, 2024
da9b52b
bug: fix app re-exports from collections pkg
josemarluedke Feb 11, 2024
7307153
chore: add tests for popover
josemarluedke Feb 12, 2024
fa823a0
docs: add documentation for popover
josemarluedke Feb 12, 2024
fc84dd7
feat: correctly handle overlay/popover nesting/stacking
josemarluedke Feb 13, 2024
46d0540
chore: add sizes to popover and more docs
josemarluedke Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions packages/collections/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@
"@frontile/overlays": "workspace:0.17.0-alpha.5",
"@frontile/theme": "workspace:0.17.0-alpha.5",
"@frontile/utilities": "workspace:0.17.0-alpha.5",
"ember-modifier": "^4.1.0",
"ember-velcro": "^2.1.3"
"ember-modifier": "^4.1.0"
},
"devDependencies": {
"@babel/core": "7.23.7",
Expand Down Expand Up @@ -88,11 +87,7 @@
"main": "addon-main.js",
"app-js": {
"./components/dropdown.js": "./dist/_app_/components/dropdown.js",
"./components/listbox.js": "./dist/_app_/components/listbox.js",
"./components/listbox/item.js": "./dist/_app_/components/listbox/item.js",
"./components/listbox/listManager.js": "./dist/_app_/components/listbox/listManager.js",
"./components/listbox/listbox.js": "./dist/_app_/components/listbox/listbox.js",
"./components/listbox/setupListItemModfier.js": "./dist/_app_/components/listbox/setupListItemModfier.js"
"./components/listbox.js": "./dist/_app_/components/listbox.js"
}
},
"exports": {
Expand Down
4 changes: 2 additions & 2 deletions packages/collections/rollup.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@ export default {
// These are the modules that users should be able to import from your
// addon. Anything not listed here may get optimized away.
addon.publicEntrypoints([
'components/**/*.js',
'components/*.js',
'index.js',
'template-registry.js'
]),

// These are the modules that should get reexported into the traditional
// "app" tree. Things in here should also be in publicEntrypoints above, but
// not everything in publicEntrypoints necessarily needs to go here.
addon.appReexports(['components/**/*.js']),
addon.appReexports(['components/*.js']),

// Follow the V2 Addon rules about dependencies. Your code can import from
// `dependencies` and `peerDependencies` as well as standard Ember-provided
Expand Down
Loading
Loading