Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix node 16 for v2 #309

Merged
merged 3 commits into from
Jun 17, 2021
Merged

fix node 16 for v2 #309

merged 3 commits into from
Jun 17, 2021

Conversation

mansona
Copy link
Contributor

@mansona mansona commented Jun 16, 2021

This PR backports the fix from #230 into v2 of workerpool.

I also backported the change to Github CI and added Node 12 14 and 16 to the test matrix in a separate commit so you can see Node 16 fail in one commit and then see it being fixed in the next 👍

@mansona mansona marked this pull request as ready for review June 16, 2021 20:32
@josdejong
Copy link
Owner

Thanks Chris, looks good 👍

@josdejong josdejong merged commit ac32508 into josdejong:v2 Jun 17, 2021
josdejong added a commit that referenced this pull request Jun 17, 2021
@josdejong
Copy link
Owner

I've just published v2.3.4.

It wasn't very straightforward: the tests where passing but the build was broken, I had to switch to a very old version of node.js, and also changed the fix to ES5 code (see 6bc5913)

@josdejong
Copy link
Owner

hm, now v2.3.4 is marked as latest on npm. Will publish a bug fix release on v6 to make that latest again...

@josdejong
Copy link
Owner

ok fixed now by publishing v6.1.5 😅

@mansona
Copy link
Contributor Author

mansona commented Jun 17, 2021

woops! thanks for sorting all that!

Also sorry I didn't notice that there was a build, I should have checked that 🙈

@josdejong
Copy link
Owner

You're welcome. Only if you try to publish a 4 year old library version again you realize how fast the ecosystem is moving...

In the latest versions of workerpool, the build is actually executed when testing, and there are tests to validate whether the generated library bundles actually do work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants