-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix node 16 for v2 #309
fix node 16 for v2 #309
Conversation
# Conflicts: # .travis.yml
# Conflicts: # src/WorkerHandler.js
Thanks Chris, looks good 👍 |
I've just published v2.3.4. It wasn't very straightforward: the tests where passing but the build was broken, I had to switch to a very old version of node.js, and also changed the fix to ES5 code (see 6bc5913) |
hm, now v2.3.4 is marked as latest on npm. Will publish a bug fix release on v6 to make that latest again... |
ok fixed now by publishing v6.1.5 😅 |
woops! thanks for sorting all that! Also sorry I didn't notice that there was a build, I should have checked that 🙈 |
You're welcome. Only if you try to publish a 4 year old library version again you realize how fast the ecosystem is moving... In the latest versions of |
This PR backports the fix from #230 into v2 of workerpool.
I also backported the change to Github CI and added Node 12 14 and 16 to the test matrix in a separate commit so you can see Node 16 fail in one commit and then see it being fixed in the next 👍