Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement count based on size #2092

Merged
merged 3 commits into from
Jan 31, 2021
Merged

Implement count based on size #2092

merged 3 commits into from
Jan 31, 2021

Conversation

Josef37
Copy link
Contributor

@Josef37 Josef37 commented Jan 27, 2021

Closes #2085

Copy link
Owner

@josdejong josdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Josef37 , looks good 👍 I made two comments about simplifying the code a bit more, and improving upon the unit tests

src/function/matrix/count.js Outdated Show resolved Hide resolved
test/unit-tests/function/matrix/count.test.js Outdated Show resolved Hide resolved
@josdejong
Copy link
Owner

Nice! Thanks for your latest improvement Josef! Will merge your PR now.

BTW not related to this speicfic PR, but I don't get why we stiff have continuous-integration/travis-ci listed in the checks, travis should be fully removed from the project (replaced with github workflow).

@josdejong josdejong merged commit bf0eedf into josdejong:develop Jan 31, 2021
@Josef37
Copy link
Contributor Author

Josef37 commented Jan 31, 2021

I've never done much on the DevOps side of things. I'm kind of lost about that 😅

@josdejong
Copy link
Owner

yes I understand, it's just that I'm triggered by it with every PR 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function for the total number of items in an array/matrix
2 participants