WIP: Bump webpack to v5 (fixes #2050)

[flaviut]

Imports are required to be done a little differently, and there needs to be a "type: module" in the package.json

[josdejong]

Thanks a lot Flaviu! I'm happily surprised that there are no config changes needed for webpack, looks quite straightforward.

A few small remarks:

1. I think the old treeShakingApp.js can be removed since you copied it to ./source.
2. I think it will be wise not to switch to karma-webpack@5.0.0-alpha.5 since it's an (unstable) alpha version, shall we await upgrading it until v5.0.0 is published for real?

EDIT: or is the upgrade of karma needed to get the integration tests running?

[flaviut]

I think the old treeShakingApp.js can be removed since you copied it to ./source.

It was, I think the github ui just didn't do a very good job making it clear.

EDIT: or is the upgrade of karma needed to get the integration tests running?

I went through and bumped everything webpack related up--but it turns out that karma-webpack doesn't need to be updated yet, unless you're experiencing these bugs. I've brought it back to v4, and test:all still works fine for me now.

[josdejong]

It was, I think the github ui just didn't do a very good job making it clear.

Ah, now I see, you're right

I see all except one of the CI tests are green. Only "Browser testing locally / browser-tests (pull_request)" gives an error. The logs say:

Cannot find plugin "/home/runner/work/mathjs/mathjs/node_modules/karma-webpack".

Which is just odd. When I run npm run test:browser locally I get an error which makes more sense:

> npm run test:browser

24 12 2020 08:51:57.789:ERROR [plugin]: Error during loading "...\mathjs\node_modules/karma-webpack" plugin:
  Cannot find module 'webpack/lib/dependencies/SingleEntryDependency'

Any ideas?

[josdejong]

Maybe we're hitting this issue: codymikol/karma-webpack#431

[josdejong]

I see some new commits here @flaviut , are you picking this up again?

Pinging @JayFate, please be aware @flaviut was also working on this (see #2094)

[flaviut]

Yup, I've had some free time lately. No promises though--fixing issues arising from dependencies 5 levels down gets frustrating quickly :)

[josdejong]

Thanks @flaviut. Yes this stuff can be very frustrating indeed!!

[josdejong]

@flaviut just to be sure you're aware of it: you can run those browser tests locally via:

npm run test:browser

[flaviut]

Yup! I've been doing a bit of both—local tests, and in CI in order to make sure the issues aren't just my local configuration being messed up. If you're getting spammed by emails, I think you can unsubscribe to this PR to get them to stop. I can email you (rather than post on GitHub) when this is ready and you can take a look.

…

On Sun, Feb 7, 2021, 16:04 Jos de Jong ***@***.***> wrote: @flaviut <https://github.com/flaviut> just to be sure you're aware of it: you can run those browser tests locally via: npm run test:browser — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2066 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABHY2HJTDWTPS4Y47UO7GKLS5354JANCNFSM4VDNVTNA> .

[gwhitney]

This appears to be superseded by a later PR, as mathjs@11.0.1 does use webpack 5. If you agree, feel free to close or let me know to.

[josdejong]

Yes 🎉 this has been addressed (it required to drop IE11 support)