forked from Azure/azure-rest-api-specs
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2021-06-01 ARM & SDK Fixes #23
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9a2bf2d.
…nErrorDetectionSettings
…ejia/dev-2021-06-01
yunheMsft
reviewed
Nov 22, 2021
...fication/cdn/resource-manager/Microsoft.Cdn/stable/2021-06-01/cdnwebapplicationfirewall.json
Show resolved
Hide resolved
Are there any Swagger examples that should be updated to be consistent with these changes? |
yunheMsft
approved these changes
Nov 23, 2021
jorinmejia
pushed a commit
that referenced
this pull request
Nov 23, 2021
* ACR Admin swagger spec changes * Release/larisab (#1) * Add swagger spec for acr setup. * Add swagger spec for acr setup - fixed jsons. * Add swagger spec for acr setup - address feedback to convert get status to post. * Add swagger spec for acr setup - fixed typo. * Add swagger spec for acr setup - added setup specs to readme. * Add swagger spec for acr setup - fixed checkSetup definitions. * Add swagger spec for acr setup - addressed comments. * Add swagger spec for acr setup - addressed ARM feedback. * Add swagger spec for acr setup - added proper input-files n readme. * Add swagger spec for acr setup - fixed inavalid scheme. * Add swagger spec for acr setup - fixed inavalid method Post instaed of Get. Co-authored-by: Larysa Borodina <larisab@microsoft.com> * Update API changes (#2) * Update API changes * Add delete call implementation * update examples * Fix swagger validation errors. (#3) * Fix swagger validation errors - 2-nd. (#4) * Fix model validation fix * Fix swagger validation errors - 3d. (#5) * Fix swagger validation errors - 4th. (#6) * Fix swagger validation errors - 4th. * Fix swagger validation errors - 5th. * Release/acrchanges (#8) * Fix swagger validation errors - 4th. * Fix swagger validation errors - 5th. * Fix swagger validation errors - 6th. * Release/acrchanges (#9) * Fix swagger validation errors - 4th. * Fix swagger validation errors - 5th. * Fix swagger validation errors - 6th. * Fix swagger validation errors - 7th. * Release/larisab (#11) * Fix swagger validation errors - 4th. * Fix swagger validation errors - 5th. * Fix swagger validation errors - 6th. * Fix swagger validation errors - 7th. * Fix swagger validation errors - 12th. * Release/acrchanges (#12) * Fix swagger validation errors - 4th. * Fix swagger validation errors - 5th. * Fix swagger validation errors - 6th. * Fix swagger validation errors - 7th. * Fix swagger validation errors - 13th. * Fix swagger validation errors - 14th. * Fix swagger validation errors - 15th. * Fix swagger validation errors - 16th. * Fix swagger validation errors - 17th. * Fix swagger validation errors - 18th. * Fix swagger validation errors - 19th. * Release/acrchanges (#13) * Fix swagger validation errors - 4th. * Fix swagger validation errors - 5th. * Fix swagger validation errors - 6th. * Fix swagger validation errors - 7th. * Fix swagger validation errors - 13th. * Fix swagger validation errors - 14th. * Fix swagger validation errors - 15th. * Fix swagger validation errors - 16th. * Fix swagger validation errors - 17th. * Fix swagger validation errors - 18th. * Fix swagger validation errors - 19th. * Fix swagger validation errors - 20th. * Release/acrchanges (#14) * Fix swagger validation errors - 4th. * Fix swagger validation errors - 5th. * Fix swagger validation errors - 6th. * Fix swagger validation errors - 7th. * Fix swagger validation errors - 13th. * Fix swagger validation errors - 14th. * Fix swagger validation errors - 15th. * Fix swagger validation errors - 16th. * Fix swagger validation errors - 17th. * Fix swagger validation errors - 18th. * Fix swagger validation errors - 19th. * Fix swagger validation errors - 20th. * Fix swagger validation errors - 21th. * Release/acrchanges (#15) * Fix swagger validation errors - 4th. * Fix swagger validation errors - 5th. * Fix swagger validation errors - 6th. * Fix swagger validation errors - 7th. * Fix swagger validation errors - 13th. * Fix swagger validation errors - 14th. * Fix swagger validation errors - 15th. * Fix swagger validation errors - 16th. * Fix swagger validation errors - 17th. * Fix swagger validation errors - 18th. * Fix swagger validation errors - 19th. * Fix swagger validation errors - 20th. * Fix swagger validation errors - 21th. * Fix swagger validation errors - 21st. * Release/acrchanges (#16) * Fix swagger validation errors - 4th. * Fix swagger validation errors - 5th. * Fix swagger validation errors - 6th. * Fix swagger validation errors - 7th. * Fix swagger validation errors - 13th. * Fix swagger validation errors - 14th. * Fix swagger validation errors - 15th. * Fix swagger validation errors - 16th. * Fix swagger validation errors - 17th. * Fix swagger validation errors - 18th. * Fix swagger validation errors - 19th. * Fix swagger validation errors - 20th. * Fix swagger validation errors - 21th. * Fix swagger validation errors - 21st. * Fix swagger validation errors - 22st. * Fix swagger validation errors - 23st. * Release/acrchanges (#17) * Fix swagger validation errors - 4th. * Fix swagger validation errors - 5th. * Fix swagger validation errors - 6th. * Fix swagger validation errors - 7th. * Fix swagger validation errors - 13th. * Fix swagger validation errors - 14th. * Fix swagger validation errors - 15th. * Fix swagger validation errors - 16th. * Fix swagger validation errors - 17th. * Fix swagger validation errors - 18th. * Fix swagger validation errors - 19th. * Fix swagger validation errors - 20th. * Fix swagger validation errors - 21th. * Fix swagger validation errors - 21st. * Fix swagger validation errors - 22st. * Fix swagger validation errors - 23st. * Fix swagger validation errors - 24st. * Release/acrchanges (#18) * Fix swagger validation errors - 4th. * Fix swagger validation errors - 5th. * Fix swagger validation errors - 6th. * Fix swagger validation errors - 7th. * Fix swagger validation errors - 13th. * Fix swagger validation errors - 14th. * Fix swagger validation errors - 15th. * Fix swagger validation errors - 16th. * Fix swagger validation errors - 17th. * Fix swagger validation errors - 18th. * Fix swagger validation errors - 19th. * Fix swagger validation errors - 20th. * Fix swagger validation errors - 21th. * Fix swagger validation errors - 21st. * Fix swagger validation errors - 22st. * Fix swagger validation errors - 23st. * Fix swagger validation errors - 24st. * Fix swagger validation errors - 25th. * Release/acrchanges (#19) * Fix swagger validation errors - 4th. * Fix swagger validation errors - 5th. * Fix swagger validation errors - 6th. * Fix swagger validation errors - 7th. * Fix swagger validation errors - 13th. * Fix swagger validation errors - 14th. * Fix swagger validation errors - 15th. * Fix swagger validation errors - 16th. * Fix swagger validation errors - 17th. * Fix swagger validation errors - 18th. * Fix swagger validation errors - 19th. * Fix swagger validation errors - 20th. * Fix swagger validation errors - 21th. * Fix swagger validation errors - 21st. * Fix swagger validation errors - 22st. * Fix swagger validation errors - 23st. * Fix swagger validation errors - 24st. * Fix swagger validation errors - 25th. * Fix swagger validation errors - 26th * Release/acrchanges (#20) * Fix swagger validation errors - 4th. * Fix swagger validation errors - 5th. * Fix swagger validation errors - 6th. * Fix swagger validation errors - 7th. * Fix swagger validation errors - 13th. * Fix swagger validation errors - 14th. * Fix swagger validation errors - 15th. * Fix swagger validation errors - 16th. * Fix swagger validation errors - 17th. * Fix swagger validation errors - 18th. * Fix swagger validation errors - 19th. * Fix swagger validation errors - 20th. * Fix swagger validation errors - 21th. * Fix swagger validation errors - 21st. * Fix swagger validation errors - 22st. * Fix swagger validation errors - 23st. * Fix swagger validation errors - 24st. * Fix swagger validation errors - 25th. * Fix swagger validation errors - 26th * Fix swagger validation errors - 27th * Fix swagger validation errors - 28th * Fix swagger validation errors - 29th * Fix swagger validation errors - 30th * Release/acrchanges (#21) * Fix swagger validation errors - 4th. * Fix swagger validation errors - 5th. * Fix swagger validation errors - 6th. * Fix swagger validation errors - 7th. * Fix swagger validation errors - 13th. * Fix swagger validation errors - 14th. * Fix swagger validation errors - 15th. * Fix swagger validation errors - 16th. * Fix swagger validation errors - 17th. * Fix swagger validation errors - 18th. * Fix swagger validation errors - 19th. * Fix swagger validation errors - 20th. * Fix swagger validation errors - 21th. * Fix swagger validation errors - 21st. * Fix swagger validation errors - 22st. * Fix swagger validation errors - 23st. * Fix swagger validation errors - 24st. * Fix swagger validation errors - 25th. * Fix swagger validation errors - 26th * Fix swagger validation errors - 27th * Fix swagger validation errors - 28th * Fix swagger validation errors - 29th * Fix swagger validation errors - 30th * Fix swagger validation errors - 31th * Release/acrchanges (#22) * Fix swagger validation errors - 4th. * Fix swagger validation errors - 5th. * Fix swagger validation errors - 6th. * Fix swagger validation errors - 7th. * Fix swagger validation errors - 13th. * Fix swagger validation errors - 14th. * Fix swagger validation errors - 15th. * Fix swagger validation errors - 16th. * Fix swagger validation errors - 17th. * Fix swagger validation errors - 18th. * Fix swagger validation errors - 19th. * Fix swagger validation errors - 20th. * Fix swagger validation errors - 21th. * Fix swagger validation errors - 21st. * Fix swagger validation errors - 22st. * Fix swagger validation errors - 23st. * Fix swagger validation errors - 24st. * Fix swagger validation errors - 25th. * Fix swagger validation errors - 26th * Fix swagger validation errors - 27th * Fix swagger validation errors - 28th * Fix swagger validation errors - 29th * Fix swagger validation errors - 30th * Fix swagger validation errors - 31th * Fix swagger specs, address comments and naming bug - 32th * Fix swagger specs, address comments and naming bug - 33th * Release/acrchanges (#23) * Fix swagger validation errors - 4th. * Fix swagger validation errors - 5th. * Fix swagger validation errors - 6th. * Fix swagger validation errors - 7th. * Fix swagger validation errors - 13th. * Fix swagger validation errors - 14th. * Fix swagger validation errors - 15th. * Fix swagger validation errors - 16th. * Fix swagger validation errors - 17th. * Fix swagger validation errors - 18th. * Fix swagger validation errors - 19th. * Fix swagger validation errors - 20th. * Fix swagger validation errors - 21th. * Fix swagger validation errors - 21st. * Fix swagger validation errors - 22st. * Fix swagger validation errors - 23st. * Fix swagger validation errors - 24st. * Fix swagger validation errors - 25th. * Fix swagger validation errors - 26th * Fix swagger validation errors - 27th * Fix swagger validation errors - 28th * Fix swagger validation errors - 29th * Fix swagger validation errors - 30th * Fix swagger validation errors - 31th * Fix swagger specs, address comments and naming bug - 32th * Fix swagger specs, address comments and naming bug - 33th * Fix swagger specs - 34th * Release/acrchanges (#24) * Fix swagger validation errors - 4th. * Fix swagger validation errors - 5th. * Fix swagger validation errors - 6th. * Fix swagger validation errors - 7th. * Fix swagger validation errors - 13th. * Fix swagger validation errors - 14th. * Fix swagger validation errors - 15th. * Fix swagger validation errors - 16th. * Fix swagger validation errors - 17th. * Fix swagger validation errors - 18th. * Fix swagger validation errors - 19th. * Fix swagger validation errors - 20th. * Fix swagger validation errors - 21th. * Fix swagger validation errors - 21st. * Fix swagger validation errors - 22st. * Fix swagger validation errors - 23st. * Fix swagger validation errors - 24st. * Fix swagger validation errors - 25th. * Fix swagger validation errors - 26th * Fix swagger validation errors - 27th * Fix swagger validation errors - 28th * Fix swagger validation errors - 29th * Fix swagger validation errors - 30th * Fix swagger validation errors - 31th * Fix swagger specs, address comments and naming bug - 32th * Fix swagger specs, address comments and naming bug - 33th * Fix swagger specs - 34th * Test cmdlet name creation with recommended operation id for quota * Test cmdlet name creation with recommended operation id * Test cmdlet name creation with recommended operation id * Test cmdlet name creation with recommended operation id * Test cmdlet name creation with recommended operation id * Release/acrchanges (#25) * Fix swagger validation errors - 4th. * Fix swagger validation errors - 5th. * Fix swagger validation errors - 6th. * Fix swagger validation errors - 7th. * Fix swagger validation errors - 13th. * Fix swagger validation errors - 14th. * Fix swagger validation errors - 15th. * Fix swagger validation errors - 16th. * Fix swagger validation errors - 17th. * Fix swagger validation errors - 18th. * Fix swagger validation errors - 19th. * Fix swagger validation errors - 20th. * Fix swagger validation errors - 21th. * Fix swagger validation errors - 21st. * Fix swagger validation errors - 22st. * Fix swagger validation errors - 23st. * Fix swagger validation errors - 24st. * Fix swagger validation errors - 25th. * Fix swagger validation errors - 26th * Fix swagger validation errors - 27th * Fix swagger validation errors - 28th * Fix swagger validation errors - 29th * Fix swagger validation errors - 30th * Fix swagger validation errors - 31th * Fix swagger specs, address comments and naming bug - 32th * Fix swagger specs, address comments and naming bug - 33th * Fix swagger specs - 34th * Test cmdlet name creation with recommended operation id for quota * Test cmdlet name creation with recommended operation id * Test cmdlet name creation with recommended operation id * Test cmdlet name creation with recommended operation id * Test cmdlet name creation with recommended operation id * Use v2 common resource types. * Release/acrchanges (#26) * Fix swagger validation errors - 4th. * Fix swagger validation errors - 5th. * Fix swagger validation errors - 6th. * Fix swagger validation errors - 7th. * Fix swagger validation errors - 13th. * Fix swagger validation errors - 14th. * Fix swagger validation errors - 15th. * Fix swagger validation errors - 16th. * Fix swagger validation errors - 17th. * Fix swagger validation errors - 18th. * Fix swagger validation errors - 19th. * Fix swagger validation errors - 20th. * Fix swagger validation errors - 21th. * Fix swagger validation errors - 21st. * Fix swagger validation errors - 22st. * Fix swagger validation errors - 23st. * Fix swagger validation errors - 24st. * Fix swagger validation errors - 25th. * Fix swagger validation errors - 26th * Fix swagger validation errors - 27th * Fix swagger validation errors - 28th * Fix swagger validation errors - 29th * Fix swagger validation errors - 30th * Fix swagger validation errors - 31th * Fix swagger specs, address comments and naming bug - 32th * Fix swagger specs, address comments and naming bug - 33th * Fix swagger specs - 34th * Test cmdlet name creation with recommended operation id for quota * Test cmdlet name creation with recommended operation id * Test cmdlet name creation with recommended operation id * Test cmdlet name creation with recommended operation id * Test cmdlet name creation with recommended operation id * Use v2 common resource types. * Use v2 common resource types for parameters also. * Release/acrchanges (#27) * Fix swagger validation errors - 4th. * Fix swagger validation errors - 5th. * Fix swagger validation errors - 6th. * Fix swagger validation errors - 7th. * Fix swagger validation errors - 13th. * Fix swagger validation errors - 14th. * Fix swagger validation errors - 15th. * Fix swagger validation errors - 16th. * Fix swagger validation errors - 17th. * Fix swagger validation errors - 18th. * Fix swagger validation errors - 19th. * Fix swagger validation errors - 20th. * Fix swagger validation errors - 21th. * Fix swagger validation errors - 21st. * Fix swagger validation errors - 22st. * Fix swagger validation errors - 23st. * Fix swagger validation errors - 24st. * Fix swagger validation errors - 25th. * Fix swagger validation errors - 26th * Fix swagger validation errors - 27th * Fix swagger validation errors - 28th * Fix swagger validation errors - 29th * Fix swagger validation errors - 30th * Fix swagger validation errors - 31th * Fix swagger specs, address comments and naming bug - 32th * Fix swagger specs, address comments and naming bug - 33th * Fix swagger specs - 34th * Test cmdlet name creation with recommended operation id for quota * Test cmdlet name creation with recommended operation id * Test cmdlet name creation with recommended operation id * Test cmdlet name creation with recommended operation id * Test cmdlet name creation with recommended operation id * Use v2 common resource types. * Use v2 common resource types for parameters also. * Use v2 common resource types for parameters also. - fixed the readme to remove unneeded file Co-authored-by: Rohit Jaini <rjaini@microsoft.com> Co-authored-by: larysaborodina <larysaborodina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.