Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fix incorrect downcast in estimated_size_bytes #1351

Conversation

jleibs
Copy link
Contributor

@jleibs jleibs commented Jan 4, 2023

Looks like this might have been a copy-and-paste error?

Added a unit-test for fixed_size_list as well.

@jleibs jleibs changed the title Fix incorrect downcast in estimated_size_bytes Fix incorrect downcast in estimated_size_bytes Jan 4, 2023
@ritchie46
Copy link
Collaborator

Thanks you @jleibs 👍

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 83.19% // Head: 83.18% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (704c4e3) compared to base (26d1b11).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1351      +/-   ##
==========================================
- Coverage   83.19%   83.18%   -0.01%     
==========================================
  Files         371      371              
  Lines       40304    40304              
==========================================
- Hits        33529    33528       -1     
- Misses       6775     6776       +1     
Impacted Files Coverage Δ
src/compute/aggregate/memory.rs 39.28% <100.00%> (+3.57%) ⬆️
src/array/binary/mod.rs 90.94% <0.00%> (-1.19%) ⬇️
src/io/ipc/read/file.rs 96.42% <0.00%> (-0.45%) ⬇️
src/offset.rs 84.89% <0.00%> (+0.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jorgecarleitao jorgecarleitao merged commit ceb51aa into jorgecarleitao:main Jan 6, 2023
@jorgecarleitao jorgecarleitao added the bug Something isn't working label Jan 6, 2023
@jorgecarleitao
Copy link
Owner

Thanks a lot, @jleibs !

ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants