This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Speeded up min_max_boolean
for the case where all values are null
#1005
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: remzi 13716567376yh@gmail.com
Changes in the PR:
For a Boolean array without
null
value. We can simply get the max value by testingarray.values.null_count < array.length
and get the min value by testingarray.values.null_count == 0
.Theoretically, the time complexity is
O(1)
asnull_count
is pre computed.